Merge pull request #43 from TechnologyEnhancedLearning/fix-last-branch-check

Fix last branch check

Author: Phil-NHS

.github/workflows/pull_request.yml

@@ -6,7 +6,6 @@ jobs:
   branch-name-check:
     name: Enforce Branch Name Convention
     runs-on: ubuntu-latest
-    #if: success() || failure()
     steps:
       - name: Validate Branch Name
         run: |
@@ -22,77 +21,77 @@ jobs:
             echo "   build-*, feat-*, fix-*, bugfix-*, hotfix-*, build-*, chore-*, ci-*, docs-*, perf-*, refactor-*, revert-*, style-*, test-*, sample-*, security-*, config-*, bugfix-*, hotfix-*"
             exit 1
           fi
-        #continue-on-error: true
 
+  # qqqq repo will need branch protection rules and PR Template
   commitlint:
     name: commitlint
-  # qqqq repo will need branch protection rules and PR Template
     runs-on: ubuntu-latest
-    #if: success() || failure()
     steps:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - uses: wagoid/commitlint-github-action@v5
         with:
           configFile: .commitlintrc.json
-        #continue-on-error: true #we dont want to package etc if bad commits also pre-commit preferred
 
 
-  gitguardian-scan:
-    name: gitguardian
-    runs-on: ubuntu-latest
-    #if: success() || failure()
-    steps:
-      - uses: actions/checkout@v3
+  # gitguardian-scan:
+    # name: gitguardian
+    # runs-on: ubuntu-latest
+    # #if: success() || failure()
+    # steps:
+      # - uses: actions/checkout@v3
 
-      - name: GitGuardian Scan
-        uses: GitGuardian/gg-shield-action@v1
-        env:
-          GITGUARDIAN_API_KEY: ${{ secrets.GITGUARDIAN_API_KEY  }}
-        #continue-on-error: true # we dont want secrets going further and the keys need to be changed if this is triggered
+      # - name: GitGuardian Scan
+        # uses: GitGuardian/gg-shield-action@v1
+        # env:
+          # GITGUARDIAN_API_KEY: ${{ secrets.GITGUARDIAN_API_KEY  }}
+        # #continue-on-error: true # we dont want secrets going further and the keys need to be changed if this is triggered
 
   Unit-Tests:
       name: todo unit tests
       runs-on: ubuntu-latest
-      #if: success() || failure()
       steps:
         - name: See other project pipeline for Tests
           run: echo "qqqq See other project pipeline for Tests this is a placeholder"
-          #continue-on-error: true
 
 
   E2E-Tests:
       name: todo e2e tests
       runs-on: ubuntu-latest
-      #if: success() || failure()
       steps:
         - name: See other project pipeline for Tests
           run: echo "qqqq See other project pipeline for Tests this is a placeholder"
-          #continue-on-error: true
+
 
   Code-Coverage:
       name: code coverage
       runs-on: ubuntu-latest
-      #if: success() || failure()
       steps:
         - name: Code Coverage
           run: echo "TODO Code Coverage"
-          #continue-on-error: true
 
-  All-Checks-Passed:
-    name: all checks passed
-    runs-on: ubuntu-latest
-    needs:
-      - branch-name-check
-      - commitlint
-      - gitguardian-scan
-      - Unit-Tests
-      - E2E-Tests
-      - Code-Coverage
-    if: ${{ success() }}
-    steps:
-     - name: all checks passed steps
-       run: echo "allow all checks to run incase multiple fails then fail here"
+  # All-Checks-Passed:
+    # name: all checks passed
+    # runs-on: ubuntu-latest
+    # needs:
+      # - branch-name-check
+      # - commitlint
+      # - gitguardian-scan
+      # - Unit-Tests
+      # - E2E-Tests
+      # - Code-Coverage
+    # #if: ${{ success() }}
+    # steps:
+     # - name: all checks passed steps
+       # run: echo "allow all checks to run incase multiple fails then fail here"
 
-
+# wanted to do it like this
+ # Code-Coverage:
+  #    name: code coverage
+  #    runs-on: ubuntu-latest
+      #if: success() || failure()
+  #    steps:
+   #     - name: Code Coverage
+  #        run: echo "TODO Code Coverage"
+          #continue-on-error: true

CHANGELOG.md

@@ -1,27 +0,0 @@
-## [9.1.4](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.1.3...v9.1.4) (2025-04-15)
-
-
-### Bug Fixes
-
-* **last:** check ([6c7a8c5](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/6c7a8c5afae46ad3aba910045a0650b3b2aaf8c7))
-
-## [9.1.4-fix-last-branch-check.1](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.1.3...v9.1.4-fix-last-branch-check.1) (2025-04-15)
-
-
-### Bug Fixes
-
-* **last:** check ([6c7a8c5](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/6c7a8c5afae46ad3aba910045a0650b3b2aaf8c7))
-
-## [9.1.3](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.1.2...v9.1.3) (2025-04-15)
-
-
-### Bug Fixes
-
-* **pull request visible check:** go ([d29ba68](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/d29ba686f77de02052b1ee79c18a73e8d71a63ee))
-
-## [9.1.3-fix-quick-pr-run-now-in-master.1](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.1.2...v9.1.3-fix-quick-pr-run-now-in-master.1) (2025-04-15)
-
-
-### Bug Fixes
-
-* **pull request visible check:** go ([d29ba68](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/d29ba686f77de02052b1ee79c18a73e8d71a63ee))