can you add folia support.

[kgncengiz]

can you add folia support.

[TechnicJelle]

Why did you close this?
Does it already work on Folia?

I haven't tested it, but if you can confirm that it works, then I can write it down in the readme.

[kgncengiz]

İ implemented the feature to my plugin but no it dont work on folia.

[TechnicJelle]

Which plugin of yours are you talking about?

[kgncengiz]

İt is not a public plugin but i can help you to implemented folia support.

[kgncengiz]

adding folia support without breaking below 1.20 support isn't possible a new branch can be added for the folia version of the plugin.

[kgncengiz]

btw update

                 <dependency>
			<groupId>com.github.BlueMap-Minecraft</groupId>
			<artifactId>BlueMapAPI</artifactId>
			<version>v2.6.1</version>
			<scope>provided</scope>
		</dependency>
		<dependency>
			<groupId>com.github.BlueMap-Minecraft</groupId>
			<artifactId>BlueNBT</artifactId>
			<version>v1.2.1</version>
		</dependency>

dependency for CVE-2022-25647 fix.

[TechnicJelle]

adding folia support without breaking below 1.20 support isn't possible a new branch can be added for the folia version of the plugin.

Ah...
Please make a separate 1.20 paper implementation, then.
Like this one: paper, but paper_1_20.

[kgncengiz]

paper API 1.20 is a MUST for folia support 1.13 API doesn't work.

[TechnicJelle]

You mentioned this, yes.
So please make a new 1.20 implementation in the impl/ directory.
That way, I can keep the Paper 1.13+ implementation that is currently here, and you can add a new Paper 1.20 implementation :)

[kgncengiz]

https://github.com/kgncengiz/BlueMapOfflinePlayerMarkersFoliaFork i made a scheduler implementation but it gives an error it can be a dependency error can you check?

[21:51:16 WARN]: [BlueMapOfflinePlayerMarkers] Global task for BlueMapOfflinePlayerMarkers v3.0-SNAPSHOT generated an exception
java.lang.NoSuchMethodError: 'void com.technicjelle.bluemapofflineplayermarkers.shadow.gson.internal.ConstructorConstructor.<init>(java.util.Map)'
        at de.bluecolored.bluenbt.BlueNBT.<init>(BlueNBT.java:45) ~[BlueMapOfflinePlayerMarkers-3.0-SNAPSHOT.jar:?]
        at com.technicjelle.bluemapofflineplayermarkers.core.fileloader.FileMarkerLoader.<clinit>(FileMarkerLoader.java:19) ~[BlueMapOfflinePlayerMarkers-3.0-SNAPSHOT.jar:?]
        at com.technicjelle.bluemapofflineplayermarkers.impl.folia1_20.Scheduler.lambda$runLater$0(Scheduler.java:26) ~[BlueMapOfflinePlayerMarkers-3.0-SNAPSHOT.jar:?]
        at io.papermc.paper.threadedregions.scheduler.FoliaGlobalRegionScheduler$GlobalScheduledTask.run(FoliaGlobalRegionScheduler.java:179) ~[folia-1.20.4.jar:?]
        at io.papermc.paper.threadedregions.scheduler.FoliaGlobalRegionScheduler.tick(FoliaGlobalRegionScheduler.java:37) ~[folia-1.20.4.jar:?]
        at io.papermc.paper.threadedregions.RegionizedServer.globalTick(RegionizedServer.java:293) ~[folia-1.20.4.jar:git-Folia-24]
        at io.papermc.paper.threadedregions.RegionizedServer$GlobalTickTickHandle.tickRegion(RegionizedServer.java:148) ~[folia-1.20.4.jar:git-Folia-24]
        at io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:404) ~[folia-1.20.4.jar:git-Folia-24]
        at ca.spottedleaf.concurrentutil.scheduler.SchedulerThreadPool$TickThreadRunner.run(SchedulerThreadPool.java:525) ~[folia-1.20.4.jar:git-Folia-24]
        at java.lang.Thread.run(Thread.java:1583) ~[?:?]
        ```

[kgncengiz]

oh btw it works but the marker is too big.

[kgncengiz]

Please feel free to ask me any questions about my folia implementation.

[TechnicJelle]

Sorry, I've been a bit busy with other things lately.
I currently don't have any questions, but I may have some later on.

I've been in the process of learning how to make BMNative addons, in the hopes of being able to port a few of my Paper plugins to BMNative addons instead, to make them work cross-platform.
I am not entirely sure whether I want to do that for BMOfflinePlayerMarkers as well, or not...

So that's why development on this plugin has been a bit stagnant.
For the time being, if people ask for a Folia version, I'll just point them to your version, okay?
I've added a link to this plugin's readme that points people to your fork!

[kgncengiz]

Alr i will publish a release for my fork with a .jar file ASAP.