Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

Totally broken by our changes last night #21

Open
ethanresnick opened this issue May 7, 2015 · 1 comment
Open

Totally broken by our changes last night #21

ethanresnick opened this issue May 7, 2015 · 1 comment

Comments

@ethanresnick
Copy link
Member

Per the JSON API spec, we updated each event's json from being something like:

{
  "id": "...", 
  "type": "...", 
  "title": "...", 
  "startDateTime": "...", 
  "links": {
    //...
  }
}

to being:

{
  "id": "...", 
  "type": "...", 
  "attributes": {
    "title": "...", 
    "startDateTime": "..."
  },
  "links": {
    //...
  }
}

That is, all the fields other than the JSON-API-defined keys (type, id, links) got moved under attributes. The JSON API spec did this to make sure that user-defined attributes don't conflict with new keys the spec might want to define (analogous to "links") in the future. But it mean's we've got to update our code here!

@AbhiAgarwal
Copy link
Member

@ethanresnick no wonder!!!!! I'll fix this now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants