Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Pumice that cannot be breaked is produced. #89

Open
TwelveYO21 opened this issue Apr 15, 2024 · 2 comments
Open

[Bug] Pumice that cannot be breaked is produced. #89

TwelveYO21 opened this issue Apr 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@TwelveYO21
Copy link

Error Behaviour

As the title suggests.
Unable to destroy pumice blooms naturally generated by volcanic vent.

Expected Behaviour

Reproduce

Minecraft.NeoForge_.1.20.1.mp4

Crash Report

No response

Mod version

caupona-1.20.1-0.4.9

Server version

neoforge-47.1.101

Other mods and plugins

No response

@TwelveYO21 TwelveYO21 added the bug Something isn't working label Apr 15, 2024
@f-raZ0R
Copy link
Contributor

f-raZ0R commented Apr 17, 2024

I actually encountered this too on a server, what other mods are you using?

It seems like there is a client-server desync going on, where the client thinks there is pumice there when there actually isn't.

ok.mp4

@unilock
Copy link

unilock commented Jul 9, 2024

FumaroleVentBlockEntity#placeFumarole likely just needs a !pLevel.isClientSide check.

public static void placeFumarole(Level pLevel, BlockPos pPos) {
RandomSource pRandom = pLevel.getRandom();
int dx = (pRandom.nextBoolean() ? 1 : -1) * (pRandom.nextInt(6));
int dz = (pRandom.nextBoolean() ? 1 : -1) * (pRandom.nextInt(6));
if (dx == 0 && dz == 0)
return;
BlockPos pendPos = pPos.offset(dx, 0, dz);
for (int i = 0; i < 3; i++) {
BlockState b0 = pLevel.getBlockState(pendPos);
BlockState b1 = pLevel.getBlockState(pendPos.below());
if (b0.isAir()) {
if (b1.getFluidState().is(Fluids.PUMICE_ON)) {
if (shouldPlacePumice(pLevel, pendPos))
pLevel.setBlockAndUpdate(pendPos, CPBlocks.PUMICE_BLOOM.get().defaultBlockState());
return;
}
}
pendPos = pendPos.below();
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants