Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http cache rules to be more effective #1870

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Mar 17, 2024

Might even work like offline mode now.

@glensc glensc self-assigned this Mar 17, 2024
@glensc glensc marked this pull request as draft March 17, 2024 18:01
@glensc
Copy link
Collaborator Author

glensc commented Mar 17, 2024

weird errors have appeared with cold cache

WARNING  Connection pool is full, discarding connection: 192-168-x-y.[redacted].plex.direct. Connection pool size: 10  
WARNING  Connection pool is full, discarding connection: 192-168-x-y.[redacted].plex.direct. Connection pool size: 10  
WARNING  Connection pool is full, discarding connection: 192-168-x-y.[redacted].plex.direct. Connection pool size: 10

comes from urllib3

site-packages/pip/_vendor/urllib3/connectionpool.py:                "Connection pool is full, discarding connection: %s. Connection pool size: %s",

EDIT: Asked question about it in requests-cache:

@glensc glensc marked this pull request as ready for review November 8, 2024 19:27
@glensc
Copy link
Collaborator Author

glensc commented Nov 8, 2024

Heavy caching may result duplicate marking as watched, i.e plex state is cached, and now another Marking as watched would make duplicate watch.

Should re-fetch item before making actual changes.

@glensc glensc marked this pull request as draft November 8, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant