Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readme file clarity #32

Open
yizexiaomu opened this issue Jul 25, 2024 · 11 comments
Open

Improve readme file clarity #32

yizexiaomu opened this issue Jul 25, 2024 · 11 comments

Comments

@yizexiaomu
Copy link

I am glad that the author dared to try very aggressive optimization on Fabric, but it is worth noting that in terms of optimization, server-side optimization such as Paper and Folia clearly have stronger stability and better optimization, and Folia has even achieved a very stable level in terms of multithreading. Therefore, I would like to politely ask the author whether the future update direction of this mod is to perform aggressive optimization on Fabric while minimizing the impact on the original version or to optimize it without considering the original features. This really has great reference value for the Fabric mod ecosystem! Thank you for the author's response!

@QPCrummer
Copy link
Contributor

This mod just ports some patches from Paper and forks over to Fabric? Fabric is already ahead of PaperMC in terms of raw performance (except scaleability). I wouldn’t be interested in using anything from Folia as the minimum requirements for Folia are honestly ridiculous for a common server owner. This mod is just some minor performance improvements in niche cases typically. I’m not trying to “get rid of Paper” or “make Paper on Fabric”. And honestly, this mod does have some improvements over Paper that I wish Paper would adopt, such as extremely fine customization in terms of the optimizations offered. This mod allows every single optimization to be enabled and disabled through out config with a wiki documenting the basic use of the optimizations.

If you have any more questions. Feel free comment then below and I will reply as soon as possible. Thank you.

@yizexiaomu
Copy link
Author

So, do you mean that most of the functions of this mod will still affect some of the features of the vanilla version

@QPCrummer
Copy link
Contributor

I would say about 50% of the optimizations technically alter vanilla mechanics. That being said, if it is a significant change that typically player would notice, then the optimization is disabled by default. If there is a noticeable difference between vanilla and this mod with a default config, then I would consider it a bug (like for example, there is an issue with lightning not spawning as frequently. It seems to be an issue with one of the PaperMC patches I ported to Mixin. I have to do them all by hand, so I'd expect mistakes here and there.)

@yizexiaomu
Copy link
Author

Will optimizing code such as multi-threaded entity loading and explosion asynchrony still have a significant impact on vanilla?

@QPCrummer
Copy link
Contributor

Well currently multithreaded entities will significantly impact your game cause it will immediately crash :P It's disabled in the "unstable" package because of this. And yes, async explosions will also noticeably affect vanilla mechanics. It has a tendency to not blow up an entire chunk of tnt. I believe it is also in the "unstable" package too.

@yizexiaomu
Copy link
Author

Have you considered adding a multi-threaded module like this mod
https://github.com/WearBlackAllDay/DimensionalThreading

@QPCrummer
Copy link
Contributor

I may implement something similar to this: https://github.com/2No2Name/worldthreader

I'll have to ask 2No for permission first though

@yizexiaomu
Copy link
Author

Thank you for your answer! I have no further questions, you can close this issues

@QPCrummer
Copy link
Contributor

Actually I'm going to keep it open because this will remind me to improve my readme file

@yizexiaomu
Copy link
Author

Actually I'm going to keep it open because this will remind me to improve my readme file

This should be a better way of handling it
By the way I may also continue to provide suggestions for this mod in the future

@QPCrummer
Copy link
Contributor

Ok, thank you very much

@QPCrummer QPCrummer changed the title What is the purpose of this mod? Improve readme file clarity Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants