Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabling mixin.fastmath.joml creates small gaps in some blocks #17

Open
VindSole opened this issue Jun 27, 2024 · 3 comments
Open

enabling mixin.fastmath.joml creates small gaps in some blocks #17

VindSole opened this issue Jun 27, 2024 · 3 comments

Comments

@VindSole
Copy link

I have been trying to get rid of this bug, narrowing it to this setting on this mod, basically it creates very small gaps on some block's corners, allowing to see the sky and caves behind like an x-ray, only seen this bug happen on gravel. Odd thing is not all affected blocks show this behavior, to see it go into a dark cave and look for, or place some gravel.

mixin.fastmath.joml = false
2024-06-27_17 23 05

mixin.fastmath.joml = true (zoom into the gravel)
2024-06-27_17 24 51

@QPCrummer
Copy link
Contributor

Do you have other mods besides Potatoptimize installed?

I’m not entirely surprised about this sort of behavior. Fast math does sacrifice precision for performance. This looks like it could be some precision issues. I’m not entirely sure if this is something fixable. I’ll see if I can reproduce this issue on my end to determine if it should or shouldn’t be fixed. Thank you for reporting this!

@VindSole
Copy link
Author

Only this mod, if you believe this is not fixable I suggest adding a few words about the issue on the readme. Thank you.

@QPCrummer
Copy link
Contributor

If I can figure out exactly which Mixin is causing this issue, then I can separate it into the "unstable" category. That way we get the most performance optimizations without sacrificing visual quality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants