You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see you're using the Script DOM Element approach to script tag injection in the Script example. While that's good and well it feels a bit kludgy given Fetch hasn't implemented yet and, using Fetch, you could handle a more general use case covering both Script and Styles with additional control and without the need to promisfy the synchronous code written.
Given many of the other APIs exposed in this project are highly UA dependent (e.g. Battery Status) and likely to be unreliable – surprisingly given the website suggests "graceful degradation" and I can't use the clipboard on known working devices – please consider reworking Script to use Fetch Injection to support Style injection in addition to adding extensibility using modern standards under a more declarative approach. Cheers.
The text was updated successfully, but these errors were encountered:
I see you're using the Script DOM Element approach to script tag injection in the Script example. While that's good and well it feels a bit kludgy given Fetch hasn't implemented yet and, using Fetch, you could handle a more general use case covering both Script and Styles with additional control and without the need to promisfy the synchronous code written.
Given many of the other APIs exposed in this project are highly UA dependent (e.g. Battery Status) and likely to be unreliable – surprisingly given the website suggests "graceful degradation" and I can't use the clipboard on known working devices – please consider reworking Script to use Fetch Injection to support Style injection in addition to adding extensibility using modern standards under a more declarative approach. Cheers.
The text was updated successfully, but these errors were encountered: