Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init to the class 'Case' #18

Open
Tanmay-901 opened this issue Oct 31, 2021 · 6 comments
Open

Add init to the class 'Case' #18

Tanmay-901 opened this issue Oct 31, 2021 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Hacktoberfest accepted issue hacktoberfest-accepted help wanted Extra attention is needed

Comments

@Tanmay-901
Copy link
Owner

add the constructor __init__() in the class Case

@Tanmay-901 Tanmay-901 added Hacktoberfest Hacktoberfest accepted issue hacktoberfest-accepted labels Oct 31, 2021
@BhagatHarsh
Copy link

Is this Issue still open? I can see that in the final_release version, there is a constructor.

@Tanmay-901
Copy link
Owner Author

Hi @BhagatHarsh, yes there is a constructor but as you can see in the home, display, and other methods there are labels, buttons, etc defined for the first time directly there, I want them to be at least declared in the init for the first time and only used in other methods. let me know if you need any further clarification. Also, let me know if there's any issue with this thought process since I haven't been able to put in much time recently to think this through.

@BhagatHarsh
Copy link

That clears my doubt, and I will try to work on the issue. The Thought process is fine. Just the issue lacked some details that you filled me in later. But it's good to leave the issue simple as participants like me and others can add their thinking to the problem and develop better solutions.

@BhagatHarsh
Copy link

I tried making the constructor, but the thing is, in this line, it called the home method without creating an object of the Case class. Hence the constructor was never called when the GUI first appeared, but when the TypeN classes call their super constructor, the GUI is rendered, and we end up with GUI just stacking upon each other, and I need help fixing that.

image

@Tanmay-901
Copy link
Owner Author

Hi @BhagatHarsh, I'm afraid I'll not be able to help you out as I mentioned earlier (I'm preoccupied at the moment). However, I'll add relevant labels so that someone can help you out in the meantime.
Also, I'm fine with it if you want to restructure the code by creating the objects first instead of directly calling methods.

I haven't been able to put in much time recently to think this through.

@Tanmay-901 Tanmay-901 added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers and removed bug Something isn't working labels Oct 10, 2022
@Tanmay-901
Copy link
Owner Author

@aakash1234567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Hacktoberfest accepted issue hacktoberfest-accepted help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants