Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create all Generic version of vectorizers #1

Open
TangoJP opened this issue Nov 25, 2018 · 0 comments
Open

Create all Generic version of vectorizers #1

TangoJP opened this issue Nov 25, 2018 · 0 comments

Comments

@TangoJP
Copy link
Owner

TangoJP commented Nov 25, 2018

Underlying tokens for the vecotrizers don’t have to be of String type. Create a refactored version that takes any Vec<Vec>.

  1. Detach vectorizers from tokenizer. Streamelined version (i.e. tokenizer -> vectorize) can be separately created later. So vectorizer should just take Vec of Vec
  2. Maybe try using Box<_> somewhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant