Skip to content

Devtools shadowDOMTarget regression when upgrading from 1.112.17 to 1.117.1 #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
reihwald opened this issue Apr 28, 2025 · 4 comments · Fixed by #4212
Closed

Devtools shadowDOMTarget regression when upgrading from 1.112.17 to 1.117.1 #4064

reihwald opened this issue Apr 28, 2025 · 4 comments · Fixed by #4212

Comments

@reihwald
Copy link
Contributor

Which project does this relate to?

Router

Describe the bug

The devtools no longer render correctly when rendering inside of a shadow dom while passing the shadowDOMTarget prop after upgrading from 1.112.17 to 1.117.1.

The devtools look like this after upgrading:

Image

They are therefore mostly unusable.

Your Example Website or App

https://stackblitz.com/edit/github-wnl18pbd?file=src%2Fmain.tsx

Steps to Reproduce the Bug or Issue

  1. Let the project launch
  2. The broken devtools should be immediately visible

Expected behavior

I'd expect the devtools to be rendered correctly as they were before this regression.

The devtools looked like this before:

Image

Screenshots or Videos

No response

Platform

  • OS: Windows
  • Browser: Firefox
  • Version: 137

Additional context

No response
@bastianplsfix
Copy link

bastianplsfix commented Apr 30, 2025 •
edited
Loading

We have the same issue. However, it seems to almost work using the TanStackRouterDevtoolsPanel but is missing some styles.

Can also add that it won't automatically hide when env is not dev.

@schiller-manuel
Copy link
Contributor

cc @birkskyum

@maxx-coffee maxx-coffee mentioned this issue May 20, 2025
Merged
@maxx-coffee
Copy link
Contributor

@bastianplsfix & @reihwald , I've added a fix for this thats waiting for review. It looks like the provider was missing from the core component.

@reihwald
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix devtools when using shadowdom maxx-coffee/router
4 participants
@maxx-coffee @schiller-manuel @reihwald @bastianplsfix