Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of multiple setCookie calls #2680

Open
ondrejvelisek opened this issue Oct 31, 2024 · 1 comment
Open

Proper handling of multiple setCookie calls #2680

ondrejvelisek opened this issue Oct 31, 2024 · 1 comment
Labels
information needed Further information is requested

Comments

@ondrejvelisek
Copy link

Which project does this relate to?

Start

Describe the bug

Hi,

Ive encountered an interesting problem.

I have server function which is setting a cookie via setCookie("user_preferences", "preference_value"). And Im calling this function from within loader multiple times.

It sets the set-cookie header in a very wierd way.

If called 4 times it includes 4 set-cookie headers and fifth set-cookie header with 4 values repeated. See screenshot.

Your Example Website or App

Dont have time now to provide. Im in hurry. Sorry. Will provide if needed.

Steps to Reproduce the Bug or Issue

Use multiple setCookie with same name in the route loader.

Expected behavior

I would expect TanStart to deduplicate and set just the last called value.

Screenshots or Videos

Image

Platform

  • OS: macOS
  • Browser: Chrome
  • Version: -

Additional context

No response

@SeanCassiere SeanCassiere added the information needed Further information is requested label Nov 1, 2024
@SeanCassiere
Copy link
Member

Please attach a reproduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
information needed Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants