-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GM_download start takes 10+ seconds now #2147
Comments
@Owyn this fix did not involve any changes that could modify timing. It only made the name parameter optional and used xhr headers in case "xhr based" download is used ("Download Mode" set to "Native" or "Default") When testing I see a background xhr request happening first in "Native" mode and no background xhr request in "Browser API" mode. So do you see this in "Browser API" or "Native" mode? If "Browser API", then I can't fix this because download is entirely handled by the browser otherwise please check whether the "xhr based" download at the background page takes that long... Thanks. |
I have "default mode" set in my Firefox TM
it might be background yes but the downloading still waits for it to end start showing "save as" window so it doesn't really matter that it's background since it's "blocking" the request still happens even tho the could you test some faraway image host to actually have a high ping to test this? e.g. one in japan or australia e.g.: https://zip.2chan.net/2/src/1723650427946.jpg (japan) before that fix - download's "save as" was definitely popping up instantly always |
In every mode except "Browser API", the file is downloaded via xhr first and only then passed to the browser to show a save dialog. It has always been like this... 🤷
Only possible in "Browser API" mode. |
(Please fill out the issue template with your details)
now when I do GM_download - it now has at least a few second delay or even like 10 seconds for the save_as window to pop_up - even if I don't use original filename but set up my own - could you perhaps make it fetch original filename only if name is null but not otherwise? should be easy to check before and not fetch the server filename making users wait for no reason
Expected Behavior
instant
Actual Behavior
can be 10 or more seconds for a save as window to pop up
Specifications
Script
Example script: https://github.com/Owyn/HandyImage/raw/master/HandyImage.user.js
example url with a video to save via CTRL+S hotkey (SFW): https://danbooru.donmai.us/posts/7905903?q=animated+rating%3Asafe
The text was updated successfully, but these errors were encountered: