Skip to content

Commit d310688

Browse files
[pre-commit.ci] pre-commit autoupdate (#36)
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/psf/black: 22.1.0 → 22.3.0](psf/black@22.1.0...22.3.0) * Update CHANGELOG + update hook version * Fix failing tests Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Damien Nguyen <[email protected]>
1 parent aac1812 commit d310688

18 files changed

+48
-34
lines changed

.pre-commit-config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ ci:
33

44
repos:
55
- repo: https://github.com/pre-commit/pre-commit-hooks
6-
rev: v4.1.0
6+
rev: v4.2.0
77
hooks:
88
- id: check-added-large-files
99
- id: check-case-conflict
@@ -38,7 +38,7 @@ repos:
3838
name: isort (python)
3939

4040
- repo: https://github.com/psf/black
41-
rev: 22.1.0
41+
rev: 22.3.0
4242
hooks:
4343
- id: black
4444
language_version: python3

CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1010
### Fixed
1111

1212
- Fixed uses of of `pylint.testutils.MessageTest` instead of `pylint.testutils.Message` for Pylint >= 2.12
13+
- Fixed failing tests due to missing `ignore_position` argument to `assertAddsMessages()`
1314

1415
### Repository
1516

16-
- Update `black` hook to v22.1.0
17+
- Update `black` hook to v22.3.0
1718
- Update `check-manifest` hook to v0.48
1819
- Update `isort` hook to v5.10.1
1920
- Update `flake8` hook to v4.0.1
20-
- Update `pre-commit/pre-commit-hooks` to v4.1.0
21+
- Update `pre-commit/pre-commit-hooks` to v4.2.0
2122
- Update `Lucas-C/pre-commit-hooks` hook to v1.1.13
2223
- Update `dangoslen/changelog-enforcer` GitHub action to v3
2324
- Update `thomaseizinger/create-pull-request` GitHub action to v1.2.2

tests/assert_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,5 @@ def test_assert_ok(self):
4949
)
5050
def test_assert_not_ok(self, s):
5151
node = astroid.extract_node(s + ' #@')
52-
with self.assertAddsMessages(MessageTest(msg_id='avoid-assert', node=node)):
52+
with self.assertAddsMessages(MessageTest(msg_id='avoid-assert', node=node), ignore_position=True):
5353
self.checker.visit_assert(node)

tests/builtin_open_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def test_builtin_open_call(self, s, os_open_mode):
8181
node = astroid.extract_node(s + ' #@')
8282
self.checker.set_os_open_allowed_modes(str(os_open_mode))
8383
if os_open_mode:
84-
with self.assertAddsMessages(MessageTest(msg_id='replace-builtin-open', node=node)):
84+
with self.assertAddsMessages(MessageTest(msg_id='replace-builtin-open', node=node), ignore_position=True):
8585
self.checker.visit_call(node)
8686
else:
8787
with self.assertNoMessages():
@@ -93,7 +93,7 @@ def test_builtin_open_with(self, s, os_open_mode):
9393
node = astroid.extract_node(s + ' #@')
9494
self.checker.set_os_open_allowed_modes(str(os_open_mode))
9595
if os_open_mode:
96-
with self.assertAddsMessages(MessageTest(msg_id='replace-builtin-open', node=node)):
96+
with self.assertAddsMessages(MessageTest(msg_id='replace-builtin-open', node=node), ignore_position=True):
9797
self.checker.visit_with(node)
9898
else:
9999
with self.assertNoMessages():

tests/eval_exec_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,5 @@ def test_eval_exec_ok(self):
5151
)
5252
def test_eval_exec_call(self, s):
5353
node = astroid.extract_node(s + ' #@')
54-
with self.assertAddsMessages(MessageTest(msg_id='avoid-eval-exec', node=node)):
54+
with self.assertAddsMessages(MessageTest(msg_id='avoid-eval-exec', node=node), ignore_position=True):
5555
self.checker.visit_call(node)

tests/jsonpickle_decode_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,5 +48,5 @@ def test_jsonpickle_decode_ok(self):
4848
)
4949
def test_jsonpickle_decode_not_ok(self, s):
5050
node = astroid.extract_node(s + ' #@')
51-
with self.assertAddsMessages(MessageTest(msg_id='avoid-jsonpickle-decode', node=node)):
51+
with self.assertAddsMessages(MessageTest(msg_id='avoid-jsonpickle-decode', node=node), ignore_position=True):
5252
self.checker.visit_call(node)

tests/marshal_load_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def test_marshal_load_ok(self):
5252
)
5353
def test_marshal_load_not_ok(self, s):
5454
node = astroid.extract_node(s + ' #@')
55-
with self.assertAddsMessages(MessageTest(msg_id='avoid-marshal-load', node=node)):
55+
with self.assertAddsMessages(MessageTest(msg_id='avoid-marshal-load', node=node), ignore_position=True):
5656
self.checker.visit_call(node)
5757

5858
@pytest.mark.parametrize(
@@ -65,5 +65,5 @@ def test_marshal_load_not_ok(self, s):
6565
)
6666
def test_marshal_open_importfrom(self, s):
6767
node = astroid.extract_node(s + ' #@')
68-
with self.assertAddsMessages(MessageTest(msg_id='avoid-marshal-load', node=node)):
68+
with self.assertAddsMessages(MessageTest(msg_id='avoid-marshal-load', node=node), ignore_position=True):
6969
self.checker.visit_importfrom(node)

tests/os_chmod_test.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,9 @@ def test_chmod(self, mocker, platform, enabled_platform, fname, arg_type, forbid
130130
print(code)
131131
node = astroid.extract_node(code)
132132
if enabled_platform and forbidden != 'S_IRGRP':
133-
with self.assertAddsMessages(MessageTest(msg_id='os-chmod-unsafe-permissions', node=node)):
133+
with self.assertAddsMessages(
134+
MessageTest(msg_id='os-chmod-unsafe-permissions', node=node), ignore_position=True
135+
):
134136
self.checker.visit_call(node)
135137
else:
136138
with self.assertNoMessages():

tests/os_mkdir_mkfifo_mknod_test.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,8 @@ def test_os_function_call(self, mocker, platform, enabled_platform, function, op
127127
msg_id=f'os-{function}-unsafe-permissions',
128128
node=node,
129129
args=(getattr(self.checker, f'_os_{function}_msg_arg'),),
130-
)
130+
),
131+
ignore_position=True,
131132
):
132133
self.checker.visit_call(node)
133134
else:

tests/os_open_test.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,8 @@ def test_os_open_call_default_modes(self, mode, arg, expected_warning):
135135
with self.assertAddsMessages(
136136
MessageTest(
137137
msg_id='os-open-unsafe-permissions', node=node, args=(getattr(self.checker, '_os_open_msg_arg'),)
138-
)
138+
),
139+
ignore_position=True,
139140
):
140141
self.checker.visit_call(node)
141142
else:
@@ -168,7 +169,8 @@ def test_os_open_call(self, mode, call_mode, arg, expected_warning):
168169
with self.assertAddsMessages(
169170
MessageTest(
170171
msg_id='os-open-unsafe-permissions', node=node, args=(getattr(self.checker, '_os_open_msg_arg'),)
171-
)
172+
),
173+
ignore_position=True,
172174
):
173175
self.checker.visit_call(node)
174176
else:
@@ -197,7 +199,9 @@ def test_os_open_with_default_modes(self, mode, call_mode, arg, expected_warning
197199
node = astroid.extract_node(call_mode.format(mode))
198200
self.checker.set_os_open_allowed_modes(arg)
199201
if expected_warning:
200-
with self.assertAddsMessages(MessageTest(msg_id='os-open-unsafe-permissions', node=node)):
202+
with self.assertAddsMessages(
203+
MessageTest(msg_id='os-open-unsafe-permissions', node=node), ignore_position=True
204+
):
201205
self.checker.visit_with(node)
202206
else:
203207
with self.assertNoMessages():
@@ -217,7 +221,9 @@ def test_os_open_with(self, mode, arg, expected_warning):
217221
node = astroid.extract_node(f'with os.open("file.txt", os.O_WRONLY, 0o{mode:o}) as fd: fd.read() #@')
218222
self.checker.set_os_open_allowed_modes(arg)
219223
if expected_warning and mode != 0o755:
220-
with self.assertAddsMessages(MessageTest(msg_id='os-open-unsafe-permissions', node=node)):
224+
with self.assertAddsMessages(
225+
MessageTest(msg_id='os-open-unsafe-permissions', node=node), ignore_position=True
226+
):
221227
self.checker.visit_with(node)
222228
else:
223229
with self.assertNoMessages():

0 commit comments

Comments
 (0)