Skip to content

fix(ui): seamlessly loop videos #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyanVoxel merged 1 commit into from
Mar 31, 2025
Merged

fix(ui): seamlessly loop videos #902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/tagstudio/qt/widgets/media_player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ def __init__(self, driver: "QtDriver") -> None:
loop_action.setChecked(self.driver.settings.loop)
loop_action.triggered.connect(lambda: self.toggle_loop())
self.loop = loop_action
self.toggle_loop()

# start the player muted
self.player.audioOutput().setMuted(True)
Expand All @@ -277,6 +278,8 @@ def toggle_loop(self) -> None:
self.driver.settings.loop = self.loop.isChecked()
self.driver.settings.save()

self.player.setLoops(-1 if self.driver.settings.loop else 1)

def apply_rounded_corners(self) -> None:
"""Apply a rounded corner effect to the video player."""
width: int = int(max(self.contentsRect().size().width(), 0))
Expand Down Expand Up @@ -468,12 +471,6 @@ def media_status_changed(self, status: QMediaPlayer.MediaStatus) -> None:
current = self.format_time(self.player.position())
duration = self.format_time(self.player.duration())
self.position_label.setText(f"{current} / {duration}")
elif status == QMediaPlayer.MediaStatus.EndOfMedia:
self.player.setPosition(0)
if self.loop.isChecked():
self.player.play()
else:
self.player.pause()

def _update_controls(self, size: QSize) -> None:
self.scene().setSceneRect(0, 0, size.width(), size.height())
Expand Down