Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "doubling" (ie. 5e Crits) #108

Open
brentleyjones opened this issue Oct 30, 2015 · 0 comments
Open

Support "doubling" (ie. 5e Crits) #108

brentleyjones opened this issue Oct 30, 2015 · 0 comments

Comments

@brentleyjones
Copy link
Member

With #70 we have the ability to support a form of D&D crits in which the damage is simply maxed. In 5e though when you crit you double the number of dice rolled. Simply evaluating an expression twice doesn't achieve this because of all of the other modifiers that can be happening, including just simple constants.

So, we need to easily be able to take an expression and "double the number of dice".

We need to be weary of #28, because if we only pick the highest, what happens when doubling that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant