From 2bd034d4128795fad26666bb88e488c70767ff57 Mon Sep 17 00:00:00 2001
From: barisgul15 <barisgul15@gmail.com>
Date: Wed, 15 Nov 2023 17:44:45 +0100
Subject: [PATCH 1/4] Script is added for eliminating duplicates in course
 contacts.

---
 .../admin/admin_tabs/course-import.gohtml     | 49 +++++++++++++------
 1 file changed, 34 insertions(+), 15 deletions(-)

diff --git a/web/template/admin/admin_tabs/course-import.gohtml b/web/template/admin/admin_tabs/course-import.gohtml
index ea3e189e9..272396b2f 100644
--- a/web/template/admin/admin_tabs/course-import.gohtml
+++ b/web/template/admin/admin_tabs/course-import.gohtml
@@ -76,21 +76,40 @@
                         </label>
                         <table>
                             <tbody>
-                                <template x-for="contact in course.contacts">
-                                    <tr class="pl-3" :class="contact.main_contact?'text-green-400':'text-3'">
-                                        <td class="px-2">
-                                            <label>
-                                                <i class="fa fa-envelope" x-show="contact.main_contact"></i>
-                                                <input class="w-auto" type="checkbox" x-model="contact.main_contact">
-                                            </label>
-                                        </td>
-                                        <td class="px-2" x-text="contact.role + ':'"></td>
-                                        <td x-text="contact.first_name + ' ' + contact.last_name" class="px-2"></td>
-                                        <td class="px-2">
-                                            <a :href="'mailto:'+contact.email" x-text="contact.email"></a>
-                                        </td>
-                                    </tr>
-                                </template>
+                            <script>
+                                /*
+                                The data coming from TUMonline sometimes duplicates contacts of a course.
+                                The elements of course.contacts has 5 attributes:
+                                first_name, last_name, email, main_contact, and role.
+                                All cases considered, the most distinctive among them is e-mail.
+                                and that's why eliminating the duplicates are down accordingly.
+                                */
+                                function filterUniqueContacts(contacts) {
+                                    const uniqueEmails = new Set();
+                                    return contacts.filter(contact => {
+                                        if (!uniqueEmails.has(contact.email)) {
+                                            uniqueEmails.add(contact.email);
+                                            return true;
+                                        }
+                                        return false;
+                                    });
+                                }
+                            </script>
+                            <template x-for="contact in filterUniqueContacts(course.contacts)">
+                                <tr class="pl-3" :class="contact.main_contact ? 'text-green-400' : 'text-3'">
+                                    <td class="px-2">
+                                        <label>
+                                            <i class="fa fa-envelope" x-show="contact.main_contact"></i>
+                                            <input class="w-auto" type="checkbox" x-model="contact.main_contact">
+                                        </label>
+                                    </td>
+                                    <td class="px-2" x-text="contact.role + ':'"></td>
+                                    <td x-text="contact.first_name + ' ' + contact.last_name" class="px-2"></td>
+                                    <td class="px-2">
+                                        <a :href="'mailto:' + contact.email" x-text="contact.email"></a>
+                                    </td>
+                                </tr>
+                            </template>
                             </tbody>
                         </table>
                         <template x-for="event in course.events">

From a1a925fb30a35540d1a5272247ff3b652a007315 Mon Sep 17 00:00:00 2001
From: barisgul15 <barisgul15@gmail.com>
Date: Fri, 17 Nov 2023 11:15:51 +0100
Subject: [PATCH 2/4] comment fix

---
 web/template/admin/admin_tabs/course-import.gohtml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/web/template/admin/admin_tabs/course-import.gohtml b/web/template/admin/admin_tabs/course-import.gohtml
index 272396b2f..7a28f5337 100644
--- a/web/template/admin/admin_tabs/course-import.gohtml
+++ b/web/template/admin/admin_tabs/course-import.gohtml
@@ -78,11 +78,11 @@
                             <tbody>
                             <script>
                                 /*
-                                The data coming from TUMonline sometimes duplicates contacts of a course.
-                                The elements of course.contacts has 5 attributes:
-                                first_name, last_name, email, main_contact, and role.
+                                The data coming from TUMonline sometimes duplicates contacts of some courses.
+                                course.contacts has 5 attributes:
+                                first_name, last_name, email, main_contact, role.
                                 All cases considered, the most distinctive among them is e-mail.
-                                and that's why eliminating the duplicates are down accordingly.
+                                and that's why duplicates are eliminated accordingly.
                                 */
                                 function filterUniqueContacts(contacts) {
                                     const uniqueEmails = new Set();

From f4d61fe8e5ad86091029c9821913ebc599f12a28 Mon Sep 17 00:00:00 2001
From: barisgul15 <barisgul15@gmail.com>
Date: Mon, 20 Nov 2023 16:18:20 +0100
Subject: [PATCH 3/4] filterUniqueContacts was moved to course-import.ts

---
 .../admin/admin_tabs/course-import.gohtml     | 21 +------------------
 web/ts/course-import.ts                       | 15 +++++++++++++
 2 files changed, 16 insertions(+), 20 deletions(-)

diff --git a/web/template/admin/admin_tabs/course-import.gohtml b/web/template/admin/admin_tabs/course-import.gohtml
index 7a28f5337..b204b309c 100644
--- a/web/template/admin/admin_tabs/course-import.gohtml
+++ b/web/template/admin/admin_tabs/course-import.gohtml
@@ -76,26 +76,7 @@
                         </label>
                         <table>
                             <tbody>
-                            <script>
-                                /*
-                                The data coming from TUMonline sometimes duplicates contacts of some courses.
-                                course.contacts has 5 attributes:
-                                first_name, last_name, email, main_contact, role.
-                                All cases considered, the most distinctive among them is e-mail.
-                                and that's why duplicates are eliminated accordingly.
-                                */
-                                function filterUniqueContacts(contacts) {
-                                    const uniqueEmails = new Set();
-                                    return contacts.filter(contact => {
-                                        if (!uniqueEmails.has(contact.email)) {
-                                            uniqueEmails.add(contact.email);
-                                            return true;
-                                        }
-                                        return false;
-                                    });
-                                }
-                            </script>
-                            <template x-for="contact in filterUniqueContacts(course.contacts)">
+                            <template x-for="contact in admin.filterUniqueContacts(course.contacts)">
                                 <tr class="pl-3" :class="contact.main_contact ? 'text-green-400' : 'text-3'">
                                     <td class="px-2">
                                         <label>
diff --git a/web/ts/course-import.ts b/web/ts/course-import.ts
index 19477089d..b82c6b366 100644
--- a/web/ts/course-import.ts
+++ b/web/ts/course-import.ts
@@ -44,3 +44,18 @@ export function addNotifyEventListeners() {
         window.location.replace("/");
     });
 }
+
+
+//The data coming from TUMonline sometimes duplicates contacts of some courses. course.contacts has 5 attributes:
+//first_name, last_name, email, main_contact, role.
+//All cases considered, the most distinctive among them is e-mail and duplicates are eliminated accordingly.
+export function filterUniqueContacts(contacts: any[]) {
+    const uniqueEmails = new Set();
+    return contacts.filter(contact => {
+        if (!uniqueEmails.has(contact.email)) {
+            uniqueEmails.add(contact.email);
+            return true;
+        }
+        return false;
+    });
+}

From d752d92bb317df36b888815de93683029fed6a6e Mon Sep 17 00:00:00 2001
From: barisgul15 <barisgul15@gmail.com>
Date: Mon, 20 Nov 2023 16:34:25 +0100
Subject: [PATCH 4/4] eslint fix

---
 web/ts/course-import.ts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/web/ts/course-import.ts b/web/ts/course-import.ts
index b82c6b366..170f35f8b 100644
--- a/web/ts/course-import.ts
+++ b/web/ts/course-import.ts
@@ -45,13 +45,12 @@ export function addNotifyEventListeners() {
     });
 }
 
-
 //The data coming from TUMonline sometimes duplicates contacts of some courses. course.contacts has 5 attributes:
 //first_name, last_name, email, main_contact, role.
 //All cases considered, the most distinctive among them is e-mail and duplicates are eliminated accordingly.
-export function filterUniqueContacts(contacts: any[]) {
+export function filterUniqueContacts(contacts) {
     const uniqueEmails = new Set();
-    return contacts.filter(contact => {
+    return contacts.filter((contact) => {
         if (!uniqueEmails.has(contact.email)) {
             uniqueEmails.add(contact.email);
             return true;