Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonplanar faces sometimes not properly merging lightmaps #669

Open
Spaghetti657 opened this issue Sep 16, 2021 · 0 comments
Open

Nonplanar faces sometimes not properly merging lightmaps #669

Spaghetti657 opened this issue Sep 16, 2021 · 0 comments

Comments

@Spaghetti657
Copy link

Spaghetti657 commented Sep 16, 2021

image

The angled brush face on the lower part of the wall is setup with a non-planar shader and intersects with another face with the same shader at its edge, so it should blend the lightmap across the faces. But as you can see it does not. Q3map2 builds from before 1.6.6 (April 2018) do not have this issue.

After going through testing various compiles It appears that a merge from 2018 caused the problem. From this pull request, specifically the addition of "origintwo" at lines 616-636 in light_ydnar.c (unsure if the link will actually work). If those changes are commented out, it results in the correct behavior:

image

I have no idea what the code is intended to do, so I am not making a pull request, but I figure someone else with more knowledge of what is going on here should look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant