-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMB Details & Hours #44 #55
Conversation
chx2
commented
Mar 1, 2021
•
edited by drewroberts
Loading
edited by drewroberts
- GmbDetails Model/Factory/Policy/Migration
- GmbHours Model/Factory/Policy/Migration
- Needs tipoff/support to tag a new release
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@drewroberts I recall that we want a model for Google MyBusiness entries; is there a specific reason why there's two tables for GMB data? It looks like both hold references to a Location model. Would it make sense compress the tables by storing daily open/close status values via a |
Let's create 2 separate models for the Google My Business Data. You can call them I like having them separate because I want to know when was the last time the main Details about the business in GMB (#44) was updated vs just an update to the hours of operation. I thought about using |
I'm going to remove Timezone from this PR and move it over to the tipoff/addresses package. |
I moved Timezones from this PR to the one in the tipoff/addresses package: |
Added the new models/factories/migrations/policies. Need to add aliases to support to fix tests |
…into chx2/feature/refactored-models
I think I didn't communicate well in issue #52 about Profile Links. That model is supposed to go into the tipoff/seo package. |
@drewroberts is there anything else that needs to be done in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🔭