Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omnia/feature/28 create nova resource flexday #29

Merged
merged 6 commits into from
Mar 11, 2021
Merged

Omnia/feature/28 create nova resource flexday #29

merged 6 commits into from
Mar 11, 2021

Conversation

devjk1
Copy link

@devjk1 devjk1 commented Mar 10, 2021

#28

  • create Nova resource FlexDay
  • register Nova resource FlexDay in FlexSchedulingServiceProvider

@devjk1
Copy link
Author

devjk1 commented Mar 11, 2021

In Model FlexDay line 56
if (date('w', $this->date->getTimestamp()) == 1) { ... }
this gets the day of the week 'w' (0-6) from the column date-timestamp
You may want to take in consideration of timezones, not sure if it is.

drewroberts
drewroberts approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ♨️

@drewroberts drewroberts merged commit 77c0ad4 into main Mar 11, 2021
@drewroberts drewroberts deleted the omnia/feature/28_create_nova_resource_flexday branch March 11, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewroberts drewroberts drewroberts approved these changes

@joshtorres joshtorres Awaiting requested review from joshtorres

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devjk1 @drewroberts