Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email Address Relationship #73

Open
drewroberts opened this issue Mar 21, 2021 · 0 comments
Open

Email Address Relationship #73

drewroberts opened this issue Mar 21, 2021 · 0 comments
Assignees
@chx2

Comments

@drewroberts
Copy link
Member

With the creation of the new Email Addresses model (TIPOFF/authorization#57), all string fields for email in this package should be replaced with a findOrCreate() relationship with that model. We can use the app('email_address') & nova('email_address') helpers added in release 1.8.3 of tipoff/support.

In addition to changing the database migrations, we should also update the model, factory, and nova resource. Later, we will have a custom nova field (TIPOFF/authorization#59) for our usage of Email Address.

Participant (#39) has an existing email field.
chx2 added a commit that referenced this issue Mar 23, 2021
@chx2
Update relationship for email #73
c199370
drewroberts added a commit that referenced this issue Mar 23, 2021
@drewroberts
Merge pull request #77 from tipoff/chx2/feature/73-email-address
4d44c34 
Update relationship for email #73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chx2 chx2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drewroberts @chx2