Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Illegal character error for valid taxa #116

Open
gregpoore opened this issue Mar 1, 2021 · 1 comment · May be fixed by #117
Open

Illegal character error for valid taxa #116

gregpoore opened this issue Mar 1, 2021 · 1 comment · May be fixed by #117

Comments

@gregpoore
Copy link

gregpoore commented Mar 1, 2021 •
edited
Loading

I'm profiling through several hundred species and noticed that at least one of them throws the following error despite being a valid species name (and having a valid BacDive entry):

ERROR: Illegal character detected! My apologies, but your search can only contain letters, numbers and white-space. Abbreviating genus names (e.g. 'B. subtilis') is not supported. Please spell out your searchTerm ('Bacillus subtilis'), don't use any 'special' characters and try again.

This is reproducible with the species Cellulomonas xylanilytica

For now, I've implemented a tryCatch() in the species loop to avoid erroring out, but this is probably a bug somewhere in the code.
@katrinleinweber katrinleinweber linked a pull request Mar 10, 2021 that will close this issue
Open
7 tasks
@katrinleinweber
Copy link
Collaborator

Wow! This was a beginner mistake on my part 😞 See #117 for the repair.

Please note that because I'm not with TIB anymore, actually getting this merged, could take some more time again. This is a hobby project for me at this time.

@katrinleinweber katrinleinweber mentioned this issue Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sanitise species names with partial matches of invalid terms correctly katrinleinweber/BacDiveR
2 participants
@gregpoore @katrinleinweber