Skip to content
This repository was archived by the owner on Nov 12, 2018. It is now read-only.

GrantToRoles not working #16

Open
Fonta opened this issue Jul 27, 2017 · 7 comments
Open

GrantToRoles not working #16

Fonta opened this issue Jul 27, 2017 · 7 comments
Assignees
Labels

Comments

@Fonta
Copy link

Fonta commented Jul 27, 2017

Heya,

Awesome to see someone still making progress on this bot.

I'm running into a problem though.
Somehow users don't get the rights they should get when they have a role.
in my config I have this:

; This group has full permissions.
[MusicMaster]
GrantToRoles = 126272553265135616 126272446419566593 126272553265135616
; UserList =
MaxSongLength = 0
MaxSongs = 0
MaxPlaylistLength = 0
AllowPlaylists = yes
InstaSkip = yes
AllowHigherVolume = yes

But the user gets this:

name: Default
command_whitelist: {'queue', 'perms', 'search', 'play', 'skip', 'id', 'clean', 'help', 'np'}
ignore_non_voice: {'skip', 'search', 'play'}
max_songs: 0
max_song_length: 1200
max_playlist_length: 0
allow_playlists: True
instaskip: False
allow_higher_volume: False

Do you know what is going wrong?

@TBK
Copy link
Owner

TBK commented Jul 29, 2017

Thanks :)

I will run some tests later tonight.

@Fonta
Copy link
Author

Fonta commented Jul 29, 2017

Created a PR for this one too. #20
I'm not really familiair with Python so I don't know why isinstance doesn't work.

@TBK
Copy link
Owner

TBK commented Jul 29, 2017

Do you run the bot via Docker or "natively"?

@Fonta
Copy link
Author

Fonta commented Jul 29, 2017

via docker.

@TBK
Copy link
Owner

TBK commented Jul 29, 2017

:( my dev pc just went belly up so I will not be able to provide a fix tonight.

I think the issue is related to incorrect matching between the group definition in permissions.ini file and the Discord group.

@Fonta
Copy link
Author

Fonta commented Jul 29, 2017

Well, everything works just fine with the in the PR suggested change.

@TBK TBK added the bug label Aug 9, 2017
@TBK TBK self-assigned this Aug 9, 2017
@Fonta
Copy link
Author

Fonta commented Sep 12, 2017

Not sure why you closed the PR, but you probably have a good reason for it.
I'll delete the branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants