-
Notifications
You must be signed in to change notification settings - Fork 19
Configure Vanilla.js app to be a PWA #85
Comments
.take |
Thanks for taking this issue! Let us know if you have any questions! |
i will try to do this , it will take some time though. I have never worked with DWA. |
Hey how's this going @Ankitv003? Don't need to do anything DWA related in this issue. Just need to convert it to a PWA. Let me know if you still want to work on it or if we should switch it off to someone else. Thank you! |
yes, i have started it today, please give me a little more time. |
Sounds good! Thank you @Ankitv003 |
Hey @blackgirlbytes, will the dependency hinder me from completing this task? |
Also, will the icon be random , or is there any icon provided ? |
Good questions. You can still turn it into a PWA without dark mode and light mode, so dont worry about the dependency. Also, I think the dwa starter react project and the dwa starter vue project have an icon. You can use the same icon that those projects are using @Ankitv003 One thing to remember is to make sure you add a playwright test as well. You can take a look at the dwa starter vue project for guidance on testing. Let me know if you have more questions! |
hey @blackgirlbytes , why can't i see manifest.json files for dwa-starter-vue or dwa-starter-react , i can see the icons , but i can't seem to find any manifest.json file, is manifest.json not created for those files and only icons are there? |
I think for vite projects, the manifest info is in the vite.config.js file @Ankitv003 |
hey @blackgirlbytes i can't seem to understand when testing on playwright , i am getting different result every time without changing my code , sometimes i get 13 test cases passed out of 21, sometimes 5. |
i have completed the issue , should i add a pr? @blackgirlbytes |
Yes please open a PR @Ankitv003 |
hi @blackgirlbytes , no rush, but can you please merge this PR, so it can be counted as one of my hacktoberfest contribution😅, or let me know if there are any changes to be made. |
Hi @Ankitv003 I cant merge it because it says there's a few merge conflicts that need to be resolved. I was taking awhile because I was trying to solve some of them, but I'm not sure of all the changes you made. Please resolve the merge conflicts so I can get this merged. thanks soooooo much for your contribution |
hey @blackgirlbytes , today is the last day of hacktoberfest ,if it is possible please merge my PR , so it can be counted as a contribution to hacktoberfest , thank you🙏! |
Configure Vanilla.js app to be a PWA
🔗 Dependencies
This issue is dependent on the completion of #84. Please ensure that issue is resolved before starting work on this task.
🚀 Goal
Convert our Vanilla.js app into a Progressive Web App (PWA). This will enable features like offline functionality.
🤔 Background
We're expanding our DWA starter collection to include Vanilla.js. This task focuses on adding PWA capabilities, which are crucial for creating modern, responsive, and offline-capable web applications.
🔑 Tasks and Acceptance Criteria
🌟 Resources
Getting Started
Questions?
If you have any questions or need clarification, please comment on this issue or join our Discord community.
Happy coding! 🎉
The text was updated successfully, but these errors were encountered: