Skip to content

Commit ad54f3b

Browse files
authored
Merge pull request #28 from TASBE/develop
Migrate bead settings form ColorModel to TASBEConfig
2 parents 0479b4b + c62e395 commit ad54f3b

File tree

8 files changed

+883
-41
lines changed

8 files changed

+883
-41
lines changed

03_flow_MEFL/exercises.m

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,7 @@
7171
CM = ColorModel(beadfile, blankfile, channels, colorfiles, colorpairfiles);
7272
CM = set_ERF_channel_name(CM, 'FITC-A'); % Name the channel we'll use for ERF units
7373
CM=set_dequantization(CM, 1); % important at low levels
74-
CM=set_bead_plot(CM, 2); % 2 = show beads for all channels, even though only FITC will be used
75-
CM=set_bead_min(CM, 1); % Don't consider beads less than this amount
74+
TASBEConfig.set('beads.rangeMin', 1); % Don't consider beads less than this (log10) amount
7675
% Things we'll talk about in the next section...
7776
CM=set_translation_plot(CM, true);
7877
CM=set_translation_channel_min(CM,[2,2,2]);
@@ -88,15 +87,15 @@
8887
% The FITC channel is the one that we will key off
8988
% The identification is pretty terrible, though!
9089
% Two things are going wrong here:
91-
% 1) We're getting smearing of peaks from autofluorescence: bead_min should be raised
90+
% 1) We're getting smearing of peaks from autofluorescence: beads.rangeMin should be raised
9291
% 2) Automatic threshold detection is not finding the right value, because there
9392
% is not a distinct enough "valley" in the FITC graph
9493
% Notice also that you got a warning that: "Warning: Bead calibration probably incorrect"
9594
% When peaks are mis-detected, this typically leads to a bad fit against the
9695
% expected sequence gaps, giving warning of failures.
9796

98-
CM=set_bead_min(CM, 2); % Don't consider beads less than this amount
99-
CM=set_bead_peak_threshold(CM, 200); % override default peak threshold
97+
TASBEConfig.set('beads.rangeMin', 2); % Don't consider beads less than this (log10) amount
98+
TASBEConfig.set('beads.peakThreshold', 200); % override default peak threshold
10099
CM = resolve(CM);
101100

102101
% We get a new warning: "Warning: Only one bead peak found, assuming brightest"

0 commit comments

Comments
 (0)