Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization total persons not aligning with total persons in academic age group visualization #418

Open
wwelling opened this issue Aug 6, 2024 · 5 comments · Fixed by #419
Labels
bug Something isn't working

Comments

@wwelling wwelling added the bug Something isn't working label Aug 6, 2024
@wwelling wwelling self-assigned this Aug 7, 2024
@wwelling
Copy link
Author

wwelling commented Aug 7, 2024

https://github.com/TAMULib/scholars-angular/blob/tamu-main/src/app/%2Bdata-and-analytics/academic-age-group/academic-age-group.component.ts#L185

The results and graphs are accurate to the persons position organization excluding the default organization which has no filter for persons included.

@wwelling
Copy link
Author

wwelling commented Aug 7, 2024

Related to #15

@wwelling
Copy link
Author

wwelling commented Aug 7, 2024

Adding a field on person for organizations that includes position organization and recursively organizations within will provide what is required to resolve.

Updating the filter to that field will resolve this problem.

      if (this.organization.id !== this.defaultId && !!this.organization.name) {
        additionalFilters.push({
          field: 'organizations',
          value: this.organization.name,
          opKey: OpKey.EQUALS
        });
      }

@wwelling
Copy link
Author

wwelling commented Aug 7, 2024

An organization field already exists and does not appear to be used yet.

https://github.com/TAMULib/scholars-discovery/blob/tamu-main/src/main/resources/templates/sparql/person/organization.sparql

@wwelling
Copy link
Author

wwelling commented Aug 7, 2024

Here is the sparql that was getting the list of people of an organization where the number of people was being rendered next to the organization name.

https://github.com/TAMULib/scholars-discovery/blob/tamu-main/src/main/resources/templates/sparql/organization/people.sparql

We could try to include all persons of an organization and all sub organizations within a single organization solr document field. Which would provide a solution to #15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
1 participant