fix query to filter on effective location #381

rhundal7 · 2024-06-24T18:47:19Z

PR for issue Books Checked Out By Call Number should filter on effective location name #378
Earlier I was setting the locationNames array to either get populated from the front end or set it to empty array and based my logic on that which was overcomplicated. I now changed it slightly. If the user selects all (more than allowed selections), in the frontend, it de-selects all selections, shows message to user. If the user still submits the form, it passes an empty array to backend, processes it (the scenario of everything) same like the scenario of nothing selected and returns the respective results. If the user selects some options, it passes that populated array to the backend and the respective where clause gets executed giving the result.

books-call-number/nodes/js/buildQuery.js

wwelling

No need to get variables using the execution context, they are already available in the JavaScript scope.

books-call-number/nodes/js/buildQuery.js

Co-authored-by: William Welling <[email protected]>

…istry into folio-sprint-18-issue-378

books-call-number/nodes/js/buildQuery.js

Co-authored-by: Kevin Day <[email protected]>

rhundal7 added 3 commits June 21, 2024 15:20

wip issue 378

f1e9be7

added print statements, untested

1eeb5e9

fixed query and cleaned up variables

361a528

rhundal7 linked an issue Jun 24, 2024 that may be closed by this pull request

Books Checked Out By Call Number should filter on effective location name #378

Open

rhundal7 requested review from a team and removed request for a team June 24, 2024 18:51

rhundal7 added 2 commits June 24, 2024 15:53

wip selecting all values in dropdown and sending to query

7d4f24b

removed unwanted code

78d85c7

rhundal7 marked this pull request as draft June 25, 2024 15:34

rhundal7 added 2 commits June 25, 2024 14:59

wip

0baaa58

fix commas for query

67c72f3

rhundal7 marked this pull request as ready for review June 28, 2024 14:32

rhundal7 requested review from a team and removed request for a team June 28, 2024 14:32

rhundal7 marked this pull request as draft June 28, 2024 15:01

rhundal7 added 2 commits June 28, 2024 12:10

added code to cleanup locationName array

2c70f32

cleaned up variable names

2e40897

rhundal7 marked this pull request as ready for review June 28, 2024 20:16

rhundal7 requested a review from a team June 28, 2024 20:54

rmathew1011 requested changes Jul 1, 2024

View reviewed changes

rhundal7 requested review from kaladay and Dbreck-TAMU July 1, 2024 16:03

Dbreck-TAMU reviewed Jul 1, 2024

View reviewed changes