Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 16] Compare match message customizations #66

Merged

Conversation

qtamu
Copy link

@qtamu qtamu commented Feb 2, 2024

Porting over message labels from dspace6 xmlui . No code changes were made

@qtamu qtamu self-assigned this Feb 2, 2024
@qtamu qtamu marked this pull request as ready for review February 2, 2024 21:33
@qtamu
Copy link
Author

qtamu commented Feb 6, 2024

Corrected indentions and trailing spaces .

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81058a5) 76.96% compared to head (f8f2eee) 76.95%.
Report is 11 commits behind head on dspace-7_x-sprint5-staging.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                      Coverage Diff                       @@
##           dspace-7_x-sprint5-staging      #66      +/-   ##
==============================================================
- Coverage                       76.96%   76.95%   -0.01%     
==============================================================
  Files                            1380     1380              
  Lines                           25715    25750      +35     
  Branches                         3218     3231      +13     
==============================================================
+ Hits                            19791    19816      +25     
- Misses                           5202     5207       +5     
- Partials                          722      727       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/assets/i18n/en.json5 Outdated Show resolved Hide resolved
@qtamu qtamu requested a review from kaladay February 6, 2024 16:54
@qtamu qtamu merged commit 54f5e91 into dspace-7_x-sprint5-staging Feb 6, 2024
4 checks passed
Copy link

@wwelling wwelling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run yarn merge-i18n -s src/themes/tamu/assets/i18n and commit the changes.

Be careful as "title" key loses its double quotes and the EOF newline will need to be added after running.

@wwelling wwelling changed the title 16 compare match message customizations [Issue 16] Compare match message customizations Feb 7, 2024
@qtamu qtamu deleted the 16-compare-match-message-customizations branch April 2, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSpace 7 Upgrade] Compare and match the customizations from messages.xml in XMLUI to dspace-angular
4 participants