Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bold Match Filter, returning an empty bold markup. #519

Open
kaladay opened this issue Jan 30, 2023 · 0 comments · Fixed by #520
Open

Bold Match Filter, returning an empty bold markup. #519

kaladay opened this issue Jan 30, 2023 · 0 comments · Fixed by #520
Assignees
@kaladay
Labels
bug Something isn't working

Comments

@kaladay
Copy link
Contributor

kaladay commented Jan 30, 2023

Describe the bug
The Bold Match Filter fails to perform sanity checks and returns an empty bold markup.

To Reproduce
Steps to reproduce the behavior:

  1. Look at the unit test, there is a comment there.
  2. Look at the code and see that it generates empty bold markup.

Expected behavior
If the text is empty or invalid, just return an empty string rather than a bold around nothing.
@kaladay kaladay added the bug Something isn't working label Jan 30, 2023
@kaladay kaladay self-assigned this Jan 30, 2023
@kaladay kaladay mentioned this issue Jan 30, 2023
Merged
6 tasks
@kaladay kaladay linked a pull request Jan 30, 2023 that will close this issue
Issue 519: Fix Bold Match Filter returning an empty bold markup. #520
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaladay kaladay

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 519: Fix Bold Match Filter returning an empty bold markup. TAMULib/SAGE
1 participant
@kaladay