Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to accommodate CatalogService restructuring and breaking API changes #19

Open
1 of 3 tasks
jsavell opened this issue Feb 22, 2021 · 1 comment
Open
1 of 3 tasks

Update to accommodate CatalogService restructuring and breaking API changes #19

jsavell opened this issue Feb 22, 2021 · 1 comment

Comments

@jsavell
Copy link
Member

jsavell commented Feb 22, 2021 •
edited
Loading

Upcoming CatalogService changes will require changes to GIFMButtonService.
https://github.com/TAMULib/CatalogService/pull/98/files

In particular, but not necessarily only:

  • GIFMButtonService will need to start using CatalogService's domain objects.
  • GIFMButtonService will need to let Spring de-serialize the CS data instead of manual object mapping
  • GIFMButtonService should be refactored to stop using reflection in this magic method for finding the value by property key
@jsavell
Copy link
Member Author

jsavell commented Apr 20, 2022 •
edited
Loading

The first item was completed while the other two turned out to be unnecessary for the standalone Catalog Service re-implementation.

I think this issue can be closed since there's no requirement for completion of the other two items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsavell