Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added href attribute to title #216

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

rmathew1011
Copy link
Contributor

@rmathew1011 rmathew1011 commented Jun 28, 2024

Description

Title Row - CAP does not link to cap website. It links to the main library webpage.

Fixes # (215)

The tl-header component has been updated so that the a tag now includes an href attribute with the value 'home'.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Visual Inspection
  • Test B

Test Configuration:

  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@rmathew1011 rmathew1011 requested a review from devangm June 28, 2024 17:59
@rmathew1011 rmathew1011 linked an issue Jun 28, 2024 that may be closed by this pull request
@rmathew1011 rmathew1011 requested a review from a team June 28, 2024 18:40
@rmathew1011 rmathew1011 changed the base branch from main to remove-ng-openseadragon-fix July 1, 2024 19:20
@wwelling wwelling linked an issue Jul 1, 2024 that may be closed by this pull request
@rmathew1011 rmathew1011 changed the base branch from remove-ng-openseadragon-fix to operational-work-sprint3-staging July 1, 2024 19:35
@rmathew1011 rmathew1011 merged commit 39b344b into operational-work-sprint3-staging Jul 2, 2024
0 of 2 checks passed
@rmathew1011 rmathew1011 deleted the title-href-edit branch July 2, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title Row - CAP does not link to cap website
2 participants