Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerize Application Using Docker #83

Open
4 tasks done
gaurangkudale opened this issue Jun 19, 2023 · 7 comments
Open
4 tasks done

Containerize Application Using Docker #83

gaurangkudale opened this issue Jun 19, 2023 · 7 comments

Comments

@gaurangkudale
Copy link

gaurangkudale commented Jun 19, 2023

This pull request aims to containerize the application using Docker, providing an isolated and reproducible environment for easier deployment and scalability. Docker allows us to package the application and its dependencies into a lightweight, portable container, ensuring consistent behavior across different environments. (For Gradle-Build branch)

Changes To-Do:

  • 1. Added a Dockerfile to the project's root directory, defining the container image's specifications and dependencies.
  • 2. Included a .dockerignore file to exclude unnecessary files and directories from the Docker build context.
  • 3. Updated the project's documentation with instructions for Docker installation and containerization.
  • 4. Added a README section detailing the Docker build and run commands for local development and deployment.

@yannicnoller Please review this Feature and provide any feedback or suggestions. Thank you!

@gaurangkudale
Copy link
Author

gaurangkudale commented Jun 19, 2023

Hi @yannicnoller

Please check the latest commit of my branch (gaurangkudale@08b0fc3)
Here I have added the dockerfile and shell script (which include all the necessary cmds to build the project)

@yannicnoller
Copy link
Member

Thanks @gaurangkudale! I will look into it.

@gaurangkudale
Copy link
Author

gaurangkudale commented Jun 27, 2023 via email

@yannicnoller
Copy link
Member

Hi @gaurangkudale! Thanks for pushing in this! I had no chance yet running your script. But from looking at your files, it looks good. At the end it would be great to also have one of the examples running, e.g., as a tutorial example and explain it in the corresponding README. Let me know if you want to have a comment on a specific aspect. Thanks!

@gaurangkudale
Copy link
Author

@yannicnoller Sure!
I'll add the running tutorial example with an updated README file.
I have one question here,
When I am trying to create the PR for the gradle-build branch it is adding the previous commits as well as the latest commit so How can I discard the previous commits and only add new commits?

@yannicnoller
Copy link
Member

Hmm not sure whether I understand it correctly. A PR basically shows what you have on your own branch (the one that you try to merge with ours). You can remove commits from your branch, if there is something that you like to change. However, we will likely simply squash your commits into one anyway.

@gaurangkudale
Copy link
Author

#86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants