Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Allow falsy values #64

Closed
wants to merge 2 commits into from
Closed

[WIP] Allow falsy values #64

wants to merge 2 commits into from

Conversation

mikemix
Copy link

@mikemix mikemix commented Aug 19, 2020

Fixes #63

@lchrusciel
Copy link
Member

Hey Mike,

thanks for your PR, however, the build is red and new logic is not tested. Without it, we cannot merge it.

@mikemix mikemix changed the title Allow falsy values [WIP] Allow falsy values Aug 19, 2020
@mikemix
Copy link
Author

mikemix commented Aug 19, 2020 •
edited
Loading

I'm aware of that, just had to start doing my usual business instead. For the moment I've changed the title to indicate the WIP status, thanks.

@lchrusciel lchrusciel added the Feature New feature proposals. label Aug 21, 2020
@mikemix mikemix closed this Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken Select filter if filtering by falsy values
2 participants
@mikemix @lchrusciel