Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of subquery to ExpressionBuilderInterface::in #311

Open
amin-recharge opened this issue Sep 6, 2023 · 2 comments
Open

Add support of subquery to ExpressionBuilderInterface::in #311

amin-recharge opened this issue Sep 6, 2023 · 2 comments

Comments

@amin-recharge
Copy link

Describe the proposed solution
In the Sylius\Component\Grid\Data\ExpressionBuilderInterface::in method, the current definition of in is:
public function in(string $field, array $values);
This means that you cannot pass a subquery to $values. Additionally, since Sylius\Bundle\GridBundle\Doctrine\ORM\ExpressionBuilder is a final class, you cannot inherit it and add this capability only for your project. It would be beneficial to modify the type of $values from array to array|string so that we can pass the subquery to it.

@jakubtobiasz jakubtobiasz transferred this issue from Sylius/Sylius Sep 6, 2023
@jakubtobiasz
Copy link
Contributor

Hello @amin-recharge 👋🏼,
I moved your issue to the SyliusGridBundle's repository. Due to BC promise, we won't be able to implement your suggestion :/.

@amin-recharge
Copy link
Author

Hey @jakubtobiasz,
Thanks for moving it to the right repository. So, what can we do? Should we add it as another method or include it in the next major release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants