Apply suggestions from code review

Author: loic425

app/Entity/Speaker.php

@@ -120,4 +120,9 @@ public function setAvatar(?SpeakerAvatar $avatar): void
     {
         $this->avatar = $avatar;
     }
+
+    public function getTalks(): Collection
+    {
+        return $this->talks;
+    }
 }

app/Repository/ConferenceRepository.php

@@ -27,20 +27,20 @@ public function __construct(ManagerRegistry $registry)
         parent::__construct($registry, Conference::class);
     }
 
-    public function findTotalConferences(\DatePeriod $datePeriod): int
+    public function getTotalConferences(\DatePeriod $datePeriod): int
     {
         $queryBuilder = $this->createQueryBuilder('o');
 
         $queryBuilder
             ->select('COUNT(o.id)')
             ->andWhere(
-                $queryBuilder->expr()->gte('o.startsAt', ':start_date'),
+                $queryBuilder->expr()->gte('o.startsAt', ':startDate'),
             )
             ->andWhere(
-                $queryBuilder->expr()->lt('o.startsAt', ':end_date'),
+                $queryBuilder->expr()->lt('o.startsAt', ':endDate'),
             )
-            ->setParameter('start_date', $datePeriod->getStartDate())
-            ->setParameter('end_date', $datePeriod->getEndDate())
+            ->setParameter('startDate', $datePeriod->getStartDate())
+            ->setParameter('endDate', $datePeriod->getEndDate())
         ;
 
         return (int) $queryBuilder->getQuery()->getSingleScalarResult();

app/Repository/SpeakerRepository.php

@@ -38,21 +38,21 @@ public function getLastSpeakers(int $numberOfSpeakers): array
         return $queryBuilder->getQuery()->getResult();
     }
 
-    public function findTotalTalks(\DatePeriod $datePeriod): int
+    public function getTotalTalks(\DatePeriod $datePeriod): int
     {
         $queryBuilder = $this->createQueryBuilder('o');
 
         $queryBuilder
             ->select('COUNT(DISTINCT o.id)')
             ->join('o.talks', 't')
             ->andWhere(
-                $queryBuilder->expr()->gte('t.startsAt', ':start_date'),
+                $queryBuilder->expr()->gte('t.startsAt', ':startDate'),
             )
             ->andWhere(
-                $queryBuilder->expr()->lt('t.startsAt', ':end_date'),
+                $queryBuilder->expr()->lt('t.startsAt', ':endDate'),
             )
-            ->setParameter('start_date', $datePeriod->getStartDate())
-            ->setParameter('end_date', $datePeriod->getEndDate())
+            ->setParameter('startDate', $datePeriod->getStartDate())
+            ->setParameter('endDate', $datePeriod->getEndDate())
         ;
 
         return (int) $queryBuilder->getQuery()->getSingleScalarResult();

app/Repository/TalkRepository.php

@@ -38,20 +38,20 @@ public function getLastTalks(int $numberOfTalks): array
         return $queryBuilder->getQuery()->getResult();
     }
 
-    public function findTotalTalks(\DatePeriod $datePeriod): int
+    public function getTotalTalks(\DatePeriod $datePeriod): int
     {
         $queryBuilder = $this->createQueryBuilder('o');
 
         $queryBuilder
             ->select('COUNT(o.id)')
             ->andWhere(
-                $queryBuilder->expr()->gte('o.startsAt', ':start_date'),
+                $queryBuilder->expr()->gte('o.startsAt', ':startDate'),
             )
             ->andWhere(
-                $queryBuilder->expr()->lt('o.startsAt', ':end_date'),
+                $queryBuilder->expr()->lt('o.startsAt', ':endDate'),
             )
-            ->setParameter('start_date', $datePeriod->getStartDate())
-            ->setParameter('end_date', $datePeriod->getEndDate())
+            ->setParameter('startDate', $datePeriod->getStartDate())
+            ->setParameter('endDate', $datePeriod->getEndDate())
         ;
 
         return (int) $queryBuilder->getQuery()->getSingleScalarResult();

app/Statistics/Provider/StatisticsProvider.php

@@ -34,9 +34,9 @@ public function provide(
     ): Statistics {
         return new Statistics(
             businessActivitySummary: new BusinessActivitySummary(
-                totalTalks: $this->talkRepository->findTotalTalks($datePeriod),
-                totalSpeakers: $this->speakerRepository->findTotalTalks($datePeriod),
-                totalConferences: $this->conferenceRepository->findTotalConferences($datePeriod),
+                totalTalks: $this->talkRepository->getTotalTalks($datePeriod),
+                totalSpeakers: $this->speakerRepository->getTotalTalks($datePeriod),
+                totalConferences: $this->conferenceRepository->getTotalConferences($datePeriod),
             ),
         );
     }

translations/messages.en.yaml

@@ -30,12 +30,12 @@ app:
         speakers: Speakers
         starts_at: Starts at
         statistics:
-            day: Jour
-            lifetime: Durée de vie
-            month: Mois
-            week: Semaine
-            2weeks: 2 Semaines
-            year: Année
+            day: Day
+            lifetime: Lifetime
+            month: Month
+            week: Week
+            2weeks: 2 Weeks
+            year: Year
         talk: Talk
         talks: Talks
         tech_one: Tech#1