chore: upgrade TS deps and stabilizing TS code (metaplex-foundation#248)

* deps: upgrade solana and metaplex-foundation deps

As part of this moved solita dep out of main `package.json` and added to
each package proper as updating across packages is easy via `yarn up`.

Updated deps:

- "@solana/web3.js": "^1.35.1"
- "@metaplex-foundation/beet": "^0.0.8",
- "@metaplex-foundation/beet-solana": "^0.0.6",
- "@metaplex-foundation/solita": "^0.1.0",
- "@metaplex-foundation/amman": "^0.1.0",

* token-metadata: add create mint method previously exposed by amman

* fixed-price: adding create mint account action

* chore: temporarily disabled flaky fixed-price test

* chore: removing member ordering eslint rule

* metaplex: fix typescript warnings

* auction: fix typescript issues

* token-vault: fixing typescript issues

* chore: update yarn.lock

* ts: stricter base tsconfig

* ts-core: fix strict violations

* ts-auction: fix TS strict violations

* tsconfig: allow err:any

* deps: upgrade to latest typescript

* ts-token-metadata: fix TS strict violations partially

- disabled strict mode for this package since the SDK is already
  re-generated on a separate branch and thus fixing this is lost time

* deps: upgrade tape

* token-metadata: fix test util organization to avoid circ refs

* deps: fix for token-metadata and candy-machine

* candy-machine: using program id exported by solita

* deps: updated yarn.lock after merge

* chore: fix TS strict violations in fixed-price

* metaplex: fix TS strict violations

* chore: change if statements for conditional builds

- the current syntax did not work as it was looking for _existence_ of
  the variables instead of their actual truethiness

* chore: fixed_price SDK action skips test since it needs validator

* token-metadata: fix lint errors

* auction: ignore eslint warnings for use of any for core struct return

* fixed-price: fix eslint warnings

* metaplex: ignore eslint warnings for use of any for core struct return

* token-vault: turning off strict temporarily as sdk redone via thlorenz/sdk/token-vault

* ci: metaplex tests need amman and thus are integration tests

* ci: fix path filters for integration test workflows

* fixed-price: fixed tests

* metaplex: adapt ammanrc to reuse base like done in other packages

* ci: fix path filter outputs for integration tests

* metaplex: fix CI integration tests by building missing programs

* ci: fix fixed-price integration workflow indentation issue

* ci: fix build-auction workflow typo

Author: thlorenz

.github/actions/build-auction/action.yml

@@ -0,0 +1,16 @@
+# Implicit dependencies
+# - actions/checkout@v2
+# - ./.github/actions/install-linux-build-deps
+# - ./.github/actions/install-solana
+# - ./.github/actions/install-rust
+
+name: Build Auction
+runs:
+  using: 'composite'
+  steps:
+    - name: build-auction-program
+      working-directory: ./auction/program
+      run: |
+        cargo +${{ env.RUST_STABLE }} build-bpf --version
+        cargo +${{ env.RUST_STABLE }} build-bpf --bpf-out-dir ../../target/deploy/
+      shell: bash

.github/actions/yarn-install-and-build/action.yml

@@ -44,33 +44,41 @@ runs:
     # token-vault and auction
 
     - name: Install and Build core
-      if: ${{ inputs.build_core }}
+      if: inputs.build_core == 'true'
       run: |
+        echo 'Install and Build core: yarn install'
         yarn install
+        echo 'Install and Build core: yarn build'
         yarn build
       working-directory: ./core/js 
       shell: bash
 
     - name: Install and Build auction
-      if: ${{ inputs.build_auction }}
+      if: inputs.build_auction == 'true'
       run: |
+        echo 'Install and Build auction: yarn install'
         yarn install
+        echo 'Install and Build auction: yarn build'
         yarn build
       working-directory: ./auction/js 
       shell: bash
 
     - name: Install and Build token-metadata
-      if: ${{ inputs.build_token_metadata }}
+      if: inputs.build_token_metadata == 'true'
       run: |
+        echo 'Install and Build token-metadata: yarn install'
         yarn install
+        echo 'Install and Build token-metadata: yarn build'
         yarn build
       working-directory: ./token-metadata/js 
       shell: bash
 
     - name: Install and Build token-vault
-      if: ${{ inputs.build_token_vault }}
+      if: inputs.build_token_vault == 'true'
       run: |
+        echo 'Install and Build token-vault: yarn install'
         yarn install
+        echo 'Install and Build token-vault: yarn build'
         yarn build
       working-directory: ./token-vault/js 
       shell: bash

.github/actions/yarn-install-and-verify/action.yml

@@ -48,33 +48,41 @@ runs:
     # token-vault and auction
 
     - name: Install and Build core
-      if: ${{ inputs.build_core }}
+      if: inputs.build_core == 'true'
       run: |
+        echo 'Install and Build core: yarn install'
         yarn install
+        echo 'Install and Build core: yarn build'
         yarn build
       working-directory: ./core/js 
       shell: bash
 
     - name: Install and Build auction
-      if: ${{ inputs.build_auction }}
+      if: inputs.build_auction == 'true'
       run: |
+        echo 'Install and Build auction: yarn install'
         yarn install
+        echo 'Install and Build auction: yarn build'
         yarn build
       working-directory: ./auction/js 
       shell: bash
 
     - name: Install and Build token-metadata
-      if: ${{ inputs.build_token_metadata }}
+      if: inputs.build_token_metadata == 'true'
       run: |
+        echo 'Install and Build token-metadata: yarn install'
         yarn install
+        echo 'Install and Build token-metadata: yarn build'
         yarn build
       working-directory: ./token-metadata/js 
       shell: bash
 
     - name: Install and Build token-vault
-      if: ${{ inputs.build_token_vault }}
+      if: inputs.build_token_vault == 'true'
       run: |
+        echo 'Install and Build token-vault: yarn install'
         yarn install
+        echo 'Install and Build token-vault: yarn build'
         yarn build
       working-directory: ./token-vault/js 
       shell: bash
@@ -93,7 +101,7 @@ runs:
       shell: bash
 
     - name: Test TypeScript
-      if: ${{ !inputs.skip_test }}
+      if: inputs.skip_test == 'false'
       run: yarn test
       working-directory: ${{ inputs.working_dir }}
       shell: bash

.github/workflows/integration-fixed-price-sale.yml

@@ -16,23 +16,25 @@ jobs:
     runs-on: ubuntu-latest
     # Set job outputs to values from filter step
     outputs:
-      code: ${{ steps.filter.outputs.code }}
+      core: ${{ steps.filter.outputs.core }}
+      package: ${{ steps.filter.outputs.package }}
     steps:
       - uses: actions/checkout@v2
       # For pull requests it's not necessary to checkout the code
       - uses: dorny/paths-filter@v2
         id: filter
         with:
           filters: |
-            code:
-              - 'core/**'
-              - 'fixed-price-sale/**'
+          core:
+            - 'core/**'
+          package:
+            - 'fixed-price-sale/**'
   build-and-integration-test-fixed-price-sale:
     runs-on: ubuntu-latest
     env:
       cache_id: program-fixed-price-sale
     needs: changes
-    if: ${{ needs.changes.outputs.code == 'true' }}
+    if: ${{ needs.changes.outputs.core == 'true' || needs.changes.outputs.package == 'true' }}
     steps:
       # Setup Deps
       - uses: actions/checkout@v2

.github/workflows/integration-metaplex.yml

@@ -0,0 +1,83 @@
+name: Integration Metaplex
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+
+env:
+  CARGO_TERM_COLOR: always
+  SOLANA_VERSION: 1.8.5
+  RUST_TOOLCHAIN: stable
+
+jobs:
+  changes:
+    runs-on: ubuntu-latest
+    # Set job outputs to values from filter step
+    outputs:
+      core: ${{ steps.filter.outputs.core }}
+      package: ${{ steps.filter.outputs.package }}
+    steps:
+    - uses: actions/checkout@v2
+    # For pull requests it's not necessary to checkout the code
+    - uses: dorny/paths-filter@v2
+      id: filter
+      with:
+        filters: |
+          core:
+            - 'core/**'
+          package:
+            - 'metaplex/**'
+  build-and-integration-test-metaplex:
+    runs-on: ubuntu-latest
+    env:
+      cache_id: program-metaplex 
+    needs: changes
+    if: ${{ needs.changes.outputs.core == 'true' || needs.changes.outputs.package == 'true' }}
+    steps:
+      # Setup Deps
+      - uses: actions/checkout@v2
+      - uses: ./.github/actions/install-linux-build-deps
+      - uses: ./.github/actions/install-solana
+        with: 
+          solana_version: ${{ env.SOLANA_VERSION }}
+      - uses: ./.github/actions/install-rust
+        with: 
+          toolchain: ${{ env.RUST_TOOLCHAIN }}
+
+      # Restore Cache from previous build/test
+      - uses: actions/cache@v2
+        with:
+          path: |
+            ~/.cargo/bin/
+            ~/.cargo/registry/index/
+            ~/.cargo/registry/cache/
+            ~/.cargo/git/db/
+            ./rust/target
+          key: ${{ env.cache_id }}-${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}-${{ env.RUSTC_HASH }}
+
+      # Build Rust Programs
+      - uses: ./.github/actions/build-token-metadata
+      - uses: ./.github/actions/build-token-vault
+      - uses: ./.github/actions/build-auction
+      - uses: ./.github/actions/build-metaplex
+
+      # Install JS SDK deps
+      - uses: ./.github/actions/yarn-install-and-build
+        with: 
+          cache_id: sdk-metaplex
+          working_dir: ./metaplex/js
+          build_token_metadata: true
+          build_token_vault: true
+          build_auction: true
+
+      # Run integration test
+      - name: start-local-test-validator
+        working-directory: ./metaplex/js
+        run: DEBUG=amman* yarn amman:start
+
+      - name: integration-test-metaplex-program
+        id: run_integration_test
+        working-directory: ./metaplex/js
+        run: DEBUG=mpl* yarn test 

.github/workflows/integration-token-metadata.yml

@@ -16,23 +16,25 @@ jobs:
     runs-on: ubuntu-latest
     # Set job outputs to values from filter step
     outputs:
-      code: ${{ steps.filter.outputs.code }}
+      core: ${{ steps.filter.outputs.core }}
+      package: ${{ steps.filter.outputs.package }}
     steps:
     - uses: actions/checkout@v2
     # For pull requests it's not necessary to checkout the code
     - uses: dorny/paths-filter@v2
       id: filter
       with:
         filters: |
-          code:
+          core:
             - 'core/**'
+          package:
             - 'token-metadata/**'
   build-and-integration-test-token-metadata:
     runs-on: ubuntu-latest
     env:
       cache_id: program-token-metadata 
     needs: changes
-    if: ${{ needs.changes.outputs.code == 'true' }}
+    if: ${{ needs.changes.outputs.core == 'true' || needs.changes.outputs.package == 'true' }}
     steps:
       # Setup Deps
       - uses: actions/checkout@v2

.github/workflows/sdk-fixed-price-sale.yml

@@ -36,3 +36,4 @@ jobs:
           cache_id: sdk-fixed-price-sale
           working_dir: ./fixed-price-sale/js
           build_token_metadata: true
+          skip_test: true

.github/workflows/sdk-metaplex.yml

@@ -38,3 +38,4 @@ jobs:
           build_auction: true
           build_token_vault: true
           build_token_metadata: true
+          skip_test: true

auction-house/js/package.json

@@ -39,17 +39,18 @@
   "author": "Metaplex Maintainers <[email protected]>",
   "license": "Apache-2.0",
   "dependencies": {
-    "@metaplex-foundation/beet": "0.0.8",
-    "@metaplex-foundation/beet-solana": "0.0.6",
+    "@metaplex-foundation/beet": "^0.0.8",
+    "@metaplex-foundation/beet-solana": "^0.0.6",
     "@metaplex-foundation/mpl-core": "0.0.4",
-    "@solana/web3.js": "^1.33.0"
+    "@solana/web3.js": "^1.35.1"
   },
   "devDependencies": {
+    "@metaplex-foundation/solita": "^0.1.0",
     "@types/tape": "^4.13.2",
     "eslint": "^8.3.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.2",
     "spok": "^1.4.3",
-    "tape": "^5.3.2"
+    "tape": "^5.5.2"
   }
 }

auction/js/package.json

@@ -39,7 +39,7 @@
   "dependencies": {
     "@metaplex-foundation/mpl-core": "^0.0.2",
     "@solana/spl-token": "^0.1.8",
-    "@solana/web3.js": "^1.31.0"
+    "@solana/web3.js": "^1.35.1"
   },
   "devDependencies": {
     "eslint": "^8.3.0",