Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the transaction status when send was submitted #114

Open
Agupane opened this issue Jun 2, 2022 · 2 comments · May be fixed by #117
Open

Show the transaction status when send was submitted #114

Agupane opened this issue Jun 2, 2022 · 2 comments · May be fixed by #117
Labels

Comments

@Agupane
Copy link
Contributor

Agupane commented Jun 2, 2022

After the sent has been made, we need to take the transaction receipt and show the information about the status of the swap to the user, telling how much confirmations are needed, and a link to the etherscan / swingby explorer

@Agupane Agupane self-assigned this Jun 8, 2022
@Agupane Agupane linked a pull request Jun 10, 2022 that will close this issue
@Agupane Agupane added question Further information is requested on hold labels Jun 13, 2022
@Agupane
Copy link
Contributor Author

Agupane commented Jun 13, 2022

I'm putting this on hold as I need some clarifications regarding how the waiting status is going to be threatened on the side of the nodes. Relevant information about how the status is generated can be found in this diagram:

https://skybridge-docs.swingby.network/technical-details/swap-lifecycle

From what I understood: we have a missing status that's currently now inside the "Waiting" status. It has to be split into: "waiting for tx to be executed" and "awaiting transfer" or something like this. Now when the transaction is not executed on the blockchain and when it is executed on the blockchain but it's waiting to be taken by the swingby nodes to process the swap, they are the same status: "Waiting".

We need to discuss internally what the approach we are going to do is gonna be: either to add the missing status directly on the frontend (which will add a lot of technical debt, as the current implementation is based 100% on the status of the nodes). Or we do the "proper" way which should be updating the status from the nodes.

CC @notatestuser @0xCryptoPusher

@Agupane Agupane removed the question Further information is requested label Jun 14, 2022
@Agupane
Copy link
Contributor Author

Agupane commented Jun 14, 2022

Update: after discussion, we are going to add the intermediate state into the UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant