Skip to content

Commit 5b41ccb

Browse files
committed
updated node version, moved env setting to before use for better build cache
1 parent 8e40115 commit 5b41ccb

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
FROM elixir:1.6.0
22

3-
ENV NODE_VERSION=8.9.2
4-
53
RUN groupadd --gid 1000 node \
64
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node
75

@@ -22,6 +20,8 @@ RUN set -ex \
2220
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key" ; \
2321
done
2422

23+
ENV NODE_VERSION=8.9.3
24+
2525
RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
2626
&& case "${dpkgArch##*-}" in \
2727
amd64) ARCH='x64';; \

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22

33
# Supported tags and respective `Dockerfile` links
44

5-
- [`1.6.0-8.9.2`, `latest` (*Dockerfile*)](https://github.com/SweetIQ/docker-elixir-node-aws/blob/master/Dockerfile)
6-
- [`1.6.0-8.9.2-slim`, `slim` (*slim/Dockerfile*)](https://github.com/SweetIQ/docker-elixir-node-aws/blob/master/alpine/Dockerfile)
7-
- [`1.6.0-8.9.2-alpine`, `alpine` (*alpine/Dockerfile*)](https://github.com/SweetIQ/docker-elixir-node-aws/blob/master/alpine/Dockerfile)
5+
- [`1.6.0-8.9.3`, `1.6.0`, `1.6`, `latest` (*Dockerfile*)](https://github.com/SweetIQ/docker-elixir-node-aws/blob/master/Dockerfile)
6+
- [`1.6.0-8.9.3-slim`, `1.6.0-slim`, `1.6-slim`, `slim` (*slim/Dockerfile*)](https://github.com/SweetIQ/docker-elixir-node-aws/blob/master/alpine/Dockerfile)
7+
- [`1.6.0-8.9.3-alpine`, `1.6.0-alpine`, `1.6-alpine`, `alpine` (*alpine/Dockerfile*)](https://github.com/SweetIQ/docker-elixir-node-aws/blob/master/alpine/Dockerfile)

alpine/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM elixir:1.6.0-alpine
22

3-
ENV NODE_VERSION=v8.9.2
3+
ENV NODE_VERSION=v8.9.3
44
ENV NPM_VERSION=5
55

66
# For base builds

slim/Dockerfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
FROM elixir:1.6.0-slim
22

3-
ENV NODE_VERSION 8.9.2
4-
53
RUN groupadd --gid 1000 node \
64
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node
75

8-
# install python and curl
6+
# install python, curl and ca-certificates
97
RUN apt-get update \
10-
&& apt-get install -y --no-install-recommends python-dev curl \
8+
&& apt-get install -y --no-install-recommends python-dev curl ca-certificates \
119
&& apt-get clean
1210

1311
# gpg keys listed at https://github.com/nodejs/node#release-team
@@ -27,6 +25,8 @@ RUN set -ex \
2725
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key" ; \
2826
done
2927

28+
ENV NODE_VERSION 8.9.3
29+
3030
RUN buildDeps='xz-utils' \
3131
&& ARCH= && dpkgArch="$(dpkg --print-architecture)" \
3232
&& case "${dpkgArch##*-}" in \

0 commit comments

Comments
 (0)