This repository was archived by the owner on Oct 10, 2025. It is now read-only.
Fix/some misc #31
Merged
Fix/some misc #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue with folder creation in concurrent environments and updates the operating mode from "backup" to "offline".
- Update test case to assert the new "offline" mode instead of "backup".
- Replace the enum member BACKUP with OFFLINE in the environment configuration.
- Refactor the folder creation logic to add a try/except block to handle concurrent folder creation scenarios and update the project version.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/unit/test_env.py | Updated test case to validate the new "offline" mode. |
| swankit/env.py | Replaced "backup" with "offline" in the enum and improved folder creation logic. |
| pyproject.toml | Bumped the project version to reflect the update. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description