Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Docker Container for Web? #179

Open
SushiWaUmai opened this issue Apr 15, 2023 · 8 comments · May be fixed by #188
Open

[Feature Request] Docker Container for Web? #179

SushiWaUmai opened this issue Apr 15, 2023 · 8 comments · May be fixed by #188
Labels

Comments

@SushiWaUmai
Copy link

PLEASE READ THIS

Is your feature request related to a problem? Please describe.
Are there any docker images for the web version of tachidesk sorayomi?
I prefer the web version of sorayomi over the default webUI provided with the tachidesk-server.

Describe the solution you'd like
Adding a docker container for the web version of sorayomi

Describe alternatives you've considered
The WebUI

Additional context
N/A

@DattatreyaReddy
Copy link
Collaborator

We don't have a docker file for Sorayomi web but you could use Sorayomi web here directly without installing

@SushiWaUmai
Copy link
Author

SushiWaUmai commented Apr 19, 2023

The problem what I'm hosting the tachidesk server on localhost which doesn't have https. So I just ended up writing my own docker file

FROM alpine as builder
RUN apk add unzip curl jq
RUN tag=$(curl -s https://api.github.com/repos/Suwayomi/Tachidesk-Sorayomi/tags | jq -r '.[0].name') && \
		curl -LO https://github.com/Suwayomi/Tachidesk-Sorayomi/releases/download/$tag/tachidesk-sorayomi-$tag-web.zip && \
		unzip tachidesk-sorayomi-$tag-web.zip -d ./static

FROM nginx:stable-alpine-slim
COPY --from=builder ./static /usr/share/nginx/html

This docker file just pulls the latest release of Sorayomi and serves it on port 80 via nginx.
I don't know if this is worth adding to the repo, but it works well.

@SushiWaUmai
Copy link
Author

Just created a public docker container on dockerhub.

https://hub.docker.com/r/sushiwaumai/tachidesk-sorayomi-web

@DattatreyaReddy
Copy link
Collaborator

Will it pull latest release from GitHub?

@DattatreyaReddy
Copy link
Collaborator

DattatreyaReddy commented May 8, 2023

else we could create a docker image directly from GitHub actions, you could raise a PR if you are interested

@DattatreyaReddy
Copy link
Collaborator

DattatreyaReddy commented May 8, 2023


You could write your workflow in the above file

use winget-publish as reference
you need to write needs: create-build so it will only execute after flutter builds all versions of Sorayomi (including web)

@SushiWaUmai
Copy link
Author

Will it pull latest release from GitHub?

The problem is that there is no way to figure out when a release is published, so it would be nice if we could move this to this repository.

@SushiWaUmai SushiWaUmai linked a pull request May 8, 2023 that will close this issue
@xAaeEx
Copy link

xAaeEx commented Nov 6, 2023

Will it pull latest release from GitHub?

The problem is that there is no way to figure out when a release is published, so it would be nice if we could move this to this repository.

Thats not completely true, releases have a latest tag (eg. https://github.com/Suwayomi/Tachidesk-Sorayomi/releases/latest) when you open it, it will reference the current latest version of the releases.

Maybe use this instead of using the github api endpoint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants