-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta] Tachidesk-Server 1.x #534
Comments
GraphQL is a powerful way query a website, it allows many different queries, with support for filtering, paging, and a bunch of other things. GraphQL allows you to build database-like queries with all the data at your fingertips, performantly.
50/50 for me, Javalin supports everything we need on the graphql side, and it would support JWT authorization, but so would Ktor which is what I would prefer.
I think it might be good to have both for a while, maybe permanently move to GraphQL once its battle tested.
JWTs would be perfect for this, JavaLin and most other frameworks support JWT since its a very common way to handle login.
This could be easily possible with minimal changes. With JWTs we could have a way to map between tokens and user ids, and with GraphQL we can make all queries internally use it with minimal changes.
100% support this, we could still temporarily support the old format, just remove the library and use Kotlinx Hocon Serialization to read it.
I would keep it since I use it for GraphQL quite a lot, it allows you to build queries in code, making it perfect for use with GraphQL.
100% Keep H2, its one of the best databases for GraphQL.
Never used Komga, but would probably be a good idea to take inspiration from them
I think we could make local source automatically in the library, either through a file watch on the local source folder or checking if there are new manga when the default category is fetched
Exporting manga to a format like ComicInfo would be a good idea, it would allow users to store their data without any changes from the source to propagate.
I prefer entry, since Tachidesk can be used for non-books as well since its just images. |
I am not a manga/manhwa reader currently but would like to get into in the future. I look primarily for ease of use to read comics. I have my own library, primarily in cbr or cbz form. There is a huge gap in the market that this software in particular fulfils for myself that the current conventional setup in the comic world does not meet. There are a few caveats too. What I am trying to get at, is that the potential is huge.
The name change is understandable - I can see the friction in some other posts Shame that this might break the Paperback extension, but I am sure a better solution will arise. |
Change databseThe ability to switch databases to something like postgres good but I domt know the postgres graphql support. Name changeName change seen appropriate. |
There are some early design decisions in the app that we can't change or is too complex or too substantial/fundamental to change with smaller incremental patches; Having these changes would call for a "rework" of the app.
Also as a desktop and (self-hosted) server application, Tachidesk is not just merely a remake of Tachiyomi anymore, it's a different solution to different problems and needs, so we should create a new vison as the only common ground we really have with Tachiyomi is support for its Extensions and backups.
The changes are up for debate.
Changes in the organization
Changes for Tachidesk-Server 1.x
com.typesafe.config
suwayomi.tachidesk
toorg.suwayomi
Changes for Tachidesk-WebUI
The text was updated successfully, but these errors were encountered: