Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A submodule points to a commit which does not exist. #32

Open
mirddes opened this issue Mar 3, 2022 · 6 comments
Open

A submodule points to a commit which does not exist. #32

mirddes opened this issue Mar 3, 2022 · 6 comments

Comments

@mirddes
Copy link

mirddes commented Mar 3, 2022

image

im probably doing something wrong.

@JeroenDeDauw
Copy link
Member

I can reproduce the issue

image

@JeroenDeDauw
Copy link
Member

Guess I have made some changes in the submodule that never got pushed to GitHub. I will look into this tomorrow.

Why are you cloning this repo anyway?

@mirddes
Copy link
Author

mirddes commented Mar 4, 2022 via email

@mirddes
Copy link
Author

mirddes commented Mar 4, 2022

Hopefully faf gets a survival tab highlighting this map, and many others like it, enabling appreciation by lots more people.

Might I ask why a recent release depreciated gamemodes? They were pretty neat. Tbh I personally only care about survival/survivalVersus.

And oh man 16 player would be epic. Thank you for this wonderful map.

@JeroenDeDauw
Copy link
Member

I had a quick look at this earlier today. The referenced commit indeed does not exist in https://github.com/SupremeCommanderMaps/EntropyLib. I did not find it locally and was also not able to get this repo to use the latest version of https://github.com/SupremeCommanderMaps/EntropyLib instead. Not very used to git submodules.

I dropped the other game modes since I never saw someone play them, and they would not fit the new name of the map. I also think it a better idea to just have different maps for the different game modes. They can have the same terrain of course, but there is no need to bundle everything together.

@JeroenDeDauw
Copy link
Member

A 16 player version would be cool yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants