Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown urls should be put in different color than bad urls #6

Open
phast184 opened this issue Sep 25, 2020 · 2 comments
Open

Unknown urls should be put in different color than bad urls #6

phast184 opened this issue Sep 25, 2020 · 2 comments

Comments

@phast184
Copy link

image

@PedroFonsecaDEV
Copy link
Contributor

Alexander is right. But I suggest removing the "(other)" after the bad. I explain:

88 } catch (err) {
89 console.log(chalk.rgb(210, 0, 0)("bad (other): ", url));
90 }

Just change line 89 to:

89 console.log(chalk.rgb(210, 0, 0)("bad: ", url));


FETCH FAIL == DEAD LINK == BAD URL

The UNKNOWN is for status that was not checked(300, 201, etc.); The "Else" will handle those.
That is not the case of the catch() that is invoked when the fetch() fails, indicating DEAD URLs.

@Supercraft888
Copy link
Owner

Thanks for the suggestions both you you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants