Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass bundleId to Siren.performCheck? #152

Open
robbeman opened this issue Jul 19, 2023 · 0 comments
Open

Pass bundleId to Siren.performCheck? #152

robbeman opened this issue Jul 19, 2023 · 0 comments

Comments

@robbeman
Copy link
Contributor

Sometimes it easier during dev to pass another bundleId to siren to test the checks. (Different scheme for dev builds.)

Call happens here:

sp-react-native-in-app-updates/src/InAppUpdates.ios.ts

Line 30 in 1540576

return Siren.performCheck({ country })

Especially since it is added to IosStartUpdateOptions it feels like something that was forgotten.
robbeman added a commit to robbeman/sp-react-native-in-app-updates that referenced this issue Jul 19, 2023
@robbeman
fix: add bundleId to checkNeedsUpdate
cd68528 
closes SudoPlz#152
@robbeman robbeman mentioned this issue Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robbeman