Docker configuration for production, development and testing #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If developers are supposed to make use of the new setup, the changes should be reflected in the README. |
Fr3dric0
reviewed
Apr 10, 2018
Dockerfile.base
Outdated
|
|
||
| ENV APP_DIR=/srv/app | ||
|
|
||
| RUN mkdir -p $APP_DIR |
There was a problem hiding this comment.
En liten kommentar. Blir ikkje dette automatisk gjort når du setter $APP_DIR til å vere WORKDIR?
Fr3dric0
reviewed
Apr 10, 2018
Dockerfile.prod
Outdated
| @@ -0,0 +1,3 @@ | |||
| FROM kapina_base:latest | |||
There was a problem hiding this comment.
Meir eit spørsmål, men er ikkje det meir anbefalt å bruke Docker sin multi-stage build, for å få til fleire nivå? Usikker korleis dette fungerer rundt docker-compose, men det ser ut til at ein skal kunne referere til target i docker-compose v3.4. Ref. docker/compose#5191 og docker/cli#430
Also use wheel to copy packages
Travis does not run latest docker-compose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-compose services for development, production, and testing.
Dockerfiles are based on Alpine Linux.
Fixes #5