test check_acyclic()

Author: alyst

src/imply/abstract.jl

@@ -23,7 +23,7 @@ function check_acyclic(A::AbstractMatrix)
         return UpperTriangular(A)
     else
         if acyclic
-            @info "Your model is acyclic, specifying the A Matrix as either Upper or Lower Triangular can have great performance benefits.\n" maxlog =
+            @warn "Your model is acyclic, specifying the A Matrix as either Upper or Lower Triangular can have great performance benefits.\n" maxlog =
                 1
         end
         return A

test/unit_tests/matrix_helpers.jl

@@ -1,6 +1,10 @@
 using StructuralEquationModels, Test, Random, SparseArrays, LinearAlgebra
 using StructuralEquationModels:
-    CommutationMatrix, transpose_linear_indices, duplication_matrix, elimination_matrix
+    CommutationMatrix,
+    check_acyclic,
+    transpose_linear_indices,
+    duplication_matrix,
+    elimination_matrix
 
 Random.seed!(73721)
 
@@ -47,3 +51,15 @@ end
     E = elimination_matrix(m)
     @test E * vec(A) == A[tril(trues(size(A)))]
 end
+
+@testset "check_acyclic()" begin
+    @test check_acyclic([1 0; 0 1]) isa LowerTriangular{Int, Matrix{Int}}
+    @test check_acyclic([1 0; 1 1]) isa LowerTriangular{Int, Matrix{Int}}
+    @test check_acyclic([1.0 1.0; 0.0 1.0]) isa UpperTriangular{Float64, Matrix{Float64}}
+
+    A = [0 1; 1 0]
+    @test check_acyclic(A) === A # returns the input if cyclic
+
+    # acyclic, but not u/l triangular
+    @test_logs (:warn, r"^Your model is acyclic") check_acyclic([0 0 0; 1 0 1; 0 0 0])
+end