-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for API 26 and above #6
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for providing this update :),
I think you should also build the APK present in:
app/keep-activities-qs-release.apk
app/build.gradle
Outdated
@@ -41,5 +37,5 @@ android { | |||
} | |||
} | |||
dependencies { | |||
compile 'com.android.support:support-annotations:25.0.1' | |||
api 'androidx.annotation:annotation:1.1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compile
has been replaced by implementation
api
is useful when you want to expose class and symbols to another module.
Here this is useless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, didn't notice that migration to AndroidX automatically used api.
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-2.14.1-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, you should run the following command:
./gradlew wrapper --gradle-version=5.4.1 --distribution-type=all
, it will update:
- gradlew
- gradlew.bat
- ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. If I remember correctly, this was no longer updating anything around gradle version 4 and 5, but there were a lot of changes since v2.14.
Regarding the release .apk, I would need release keystore to sign it. Or is it just the debug apk? |
Yes, the APK is signed.
So I guess this is signed. |
ActivityManagerNative
was deprecated in API 26 and most of the functionality, includingsetAlwaysFinish()
moved toActivityManager
.setAlwaysFinish()
onActivityManager
on API 26 and abovesetAlwaysFinish()
onActivityManagerNative
on API 24 and API 25Log.e
statement to allow debugging potential issues more easily in the future.Tested with emulators on API level 25, 26, 28 and 29. All work as expected.
The required permissions have not changed, so running the same adb commands is still necessary.
This fixes #4 and should also fix #5