Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(modern ST) Constellation line different IAU web site's one. #3865

Closed
3domennotry opened this issue Aug 26, 2024 · 3 comments
Closed

(modern ST) Constellation line different IAU web site's one. #3865

3domennotry opened this issue Aug 26, 2024 · 3 comments
Assignees
Labels
data Missing/bad/outdated data, but no code error state: published The fix has been published for testing in weekly binary package
Milestone

Comments

@3domennotry
Copy link

Please look at:
#3806

Sorry, I did not notice that.

/Stellarium/skycultures/modern_iau/constellationship.fab
/Stellarium/skycultures/modern_st/constellationship.fab

These files are identical.
When one file is modified, the other file should also be modified.

System

  • Stellarium version: stellarium-24.2-qt5-win32.exe

    • stellarium-24.2-98544be-patch-qt5-win32.exe
    • stellarium-24.2-623f996-patch-qt5-win32.exe
    • stellarium-24.2-19f4d98-patch-qt5-win32.exe
  • Operating system: Win7 32bit

(Sorry, I can not speak English very well.)

thank you.

@alex-w alex-w added this to the 24.3 milestone Aug 26, 2024
@alex-w alex-w added the data Missing/bad/outdated data, but no code error label Aug 26, 2024
@gzotti
Copy link
Member

gzotti commented Aug 26, 2024

IAU does not prescribe constellation stick figures, only borders and (lately) star names. S&T proposes stick figures which are used in common IAU/S&T PR material. If there is a difference between S&T's lines and our attempt to reproduce them, it needs first and foremost to be fixed in modern_st.
Maybe we should in addition find a way to cross-reference items, like: constellationship_from = modern_st in info.ini. This could reduce such duplication and avoid errors. A sky culture that does not care about star names could refer to modern_iau or the default modern. Similarly, artwork could have a reference entry to modern (but explicit entry - without entry it's "no artwork"). It may even be possible to e.g. "inherit most from Skyculture A's artwork, and overwrite/extend a few own entries". A problem may then be the references.
OTOH, a completely new format has been defined already which we must review in the coming weeks.

@alex-w alex-w closed this as completed in eb47095 Aug 28, 2024
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Sep 8, 2024
Copy link

github-actions bot commented Sep 8, 2024

Hello @3domennotry!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@3domennotry
Copy link
Author

I have confirmed that this bug has been fixed in stellarium-24.2-2c2b03d-qt5-win64.exe (full package).

(I have both environments win7 32bit and win7 64bit.
32bit win7 packages is not release.)

Thank you very much.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Missing/bad/outdated data, but no code error state: published The fix has been published for testing in weekly binary package
Development

No branches or pull requests

3 participants