-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifacts on very short total eclipses (ShowMySky) #3729
Comments
Hello @Atque! OK, developers can reproduce the issue. Thanks for the report! |
Indeed, for this eclipse it looks even worse. |
No, W11 Optimus notebook with Geforce RTX 3070Ti. Driver version 546.01. |
OK, I've noticed something much more subtle on Intel, see the screenshot below. Looks like the roughly same ellipse(s), but apparently, while your systems generate NaNs at some of the broken pixels, mine just yields some very imprecise numbers. But at least I can reproduce the presence of some artifacts. |
Does the patch in eclipse-artifacts-fix branch fix this for you? I no longer have the artifacts on Intel UHD Graphics 620 with this. |
Note that this is applied to the default ShowMySky atmosphere, so you should be using it for testing, not some custom one. Or you can patch your custom model. |
Yes, that appears to work for me as well. Great work! |
I tried compiling last night. Some process appears to block my stellarium build (compiler cannot overwrite an "open" file stellarium.exe while "still in use"). But process explorer, OpenedFilesView and whatever other tools I tried don't see why stellarium.exe should be open. Zombies on Windows? Seems I must finally restart my system, but another longish process is still running. Hopefully in late afternoon (6hrs). |
You can simply paste the |
You might be able to rename it... Also, there are tools like Unlocker that make it possible to release files from being "in use", so you may have some success with this. |
Or indeed, you can just direct Stellarium to the source path to find the updated atmosphere, without any copy-pasting anything. |
The patch is perfect for me |
Are you on NVIDIA? |
I can't detect this on AMD. |
So yes, the look is of exactly the same kind as what I had on Intel before the fix. NVIDIA is infamous for its very aggressive optimizer, which in particular assumes that the arithmetic is associative while it's not—due to rounding. And the expression here is sensitive to the order of additions & subtractions, which is why things break. Apparently, I'll have to hide the difference somehow to inhibit this optimization. |
I've pushed 634db3d, please try it. If it doesn't help, I'll have to make an uglier hack. |
Yes, that solved it, thanks! |
Hello @Atque! Please check the fresh version (development snapshot) of Stellarium: |
Hello @Atque! Please check the latest stable version of Stellarium: |
This was briefly mentioned but not properly reported in #3720.
Very precise total solar eclipses, such as the 3rd October 1986 eclipse, show a strange dark and pixelated halo around the Sun, using
eclipse simulation quality = 3.
See the screenshot below:Strangely enough, it does not appear on my MacBook, despite the same settings (
flag_atmosphere_dynamic_resolution = true
andatmosphere_resolution_reduction = 4
, otherwise mode 3 is almost unusable).System: Windows 10 64-bit
GPU: AMD Radeon RX 5700 XT (driver 24.4.1)
The text was updated successfully, but these errors were encountered: