Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD now installs manpages under $PREFIX/share/man/manX #3612

Closed
danfe opened this issue Jan 29, 2024 · 5 comments
Closed

FreeBSD now installs manpages under $PREFIX/share/man/manX #3612

danfe opened this issue Jan 29, 2024 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement Improve existing functionality
Milestone

Comments

@danfe
Copy link

danfe commented Jan 29, 2024

To help reduce the differences with most GNU/Linux distributions (and amount of ad hoc patches because of it), FreeBSD had decided to install manpages under $PREFIX/share/man/manX vs. old location of $PREFIX/man/manX, where X is the section number/name. Consider the following patch for Stellarium (it also simplifies the logic as now there's no special check for kFreeBSD):

--- doc/CMakeLists.txt.orig
+++ doc/CMakeLists.txt
@@ -22,11 +22,11 @@ IF(UNIX AND NOT WIN32 AND NOT APPLE)
 
-     IF(${CMAKE_SYSTEM_NAME} MATCHES "(DragonFly|FreeBSD|NetBSD|OpenBSD)" AND NOT ${CMAKE_SYSTEM_NAME} MATCHES "kFreeBSD")
+     IF(${CMAKE_SYSTEM_NAME} MATCHES "(DragonFly|NetBSD|OpenBSD)")
           INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/stellarium.1 DESTINATION man/man1)
-     ELSE(${CMAKE_SYSTEM_NAME} MATCHES "(DragonFly|FreeBSD|NetBSD|OpenBSD)" AND NOT ${CMAKE_SYSTEM_NAME} MATCHES "kFreeBSD")
+     ELSE(${CMAKE_SYSTEM_NAME} MATCHES "(DragonFly|NetBSD|OpenBSD)")
           INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/stellarium.1 DESTINATION share/man/man1)
-     ENDIF(${CMAKE_SYSTEM_NAME} MATCHES "(DragonFly|FreeBSD|NetBSD|OpenBSD)" AND NOT ${CMAKE_SYSTEM_NAME} MATCHES "kFreeBSD")
+     ENDIF(${CMAKE_SYSTEM_NAME} MATCHES "(DragonFly|NetBSD|OpenBSD)")
 ENDIF(UNIX AND NOT WIN32 AND NOT APPLE)
@alex-w alex-w self-assigned this Jan 29, 2024
@alex-w alex-w added this to the 24.1 milestone Jan 29, 2024
@alex-w alex-w added documentation Improvements or additions to documentation enhancement Improve existing functionality labels Jan 29, 2024
Copy link

Thank you for suggesting documentation improvement.

Copy link

Hello @danfe!

Thank you for suggesting this enhancement.

@alex-w alex-w closed this as completed in 7984aaa Jan 29, 2024
@danfe
Copy link
Author

danfe commented Jan 29, 2024

Wow that was fast! Thank you Alex!

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Feb 3, 2024
Copy link

github-actions bot commented Feb 3, 2024

Hello @danfe!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 26, 2024
Copy link

Hello @danfe!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Improve existing functionality
Development

No branches or pull requests

2 participants